FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-96975: Skip incomplete frames in `PyEval_GetFrame` by brandtbucher · Pull Request #97003 · python/cpython · GitHub

/ cpython Public

GH-96975: Skip incomplete frames in PyEval_GetFrame - #97003

Merged
brandtbucher merged 4 commits into
python:mainfrom
brandtbucher:pyeval-getframe
Sep 22, 2022
ConversationCommits (4)ChecksFiles changed
Merged

GH-96975: Skip incomplete frames in PyEval_GetFrame#97003
brandtbucher merged 4 commits into
python:mainfrom
brandtbucher:pyeval-getframe

Conversation

brandtbucher commented Sep 21, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes labels Sep 21, 2022
brandtbucher self-assigned this Sep 21, 2022
ericsnowcurrently approved these changes Sep 22, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Mostly LGTM

I've left a few minor comments but leave it to you to decide.

(I'm approving under the assumption you will get it right before merging.)

Comment thread Programs/_testembed.c Outdated
Comment thread Programs/_testembed.c
Comment thread Programs/_testembed.c Outdated
Comment thread Python/ceval.c
ericsnowcurrently approved these changes Sep 22, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

brandtbucher merged commit 8fd2c3b into python:main Sep 22, 2022

miss-islington commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot commented Sep 22, 2022

Copy link
Copy Markdown

GH-97018 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2022
pythonGH-96975: Skip incomplete frames in PyEval_GetFrame (pythonGH-9…
3f60d68 
…7003)

(cherry picked from commit 8fd2c3b)

Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes
pablogsal Awaiting requested review from pablogsal
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL