FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-34922: Fixed integer overflow in the digest() and hexdigest() methods by serhiy-storchaka · Pull Request #9751 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-34922: Fixed integer overflow in the digest() and hexdigest() methods - #9751

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:hashlib-digest-overflow
Oct 11, 2018
ConversationCommits (1)ChecksFiles changed
Merged

bpo-34922: Fixed integer overflow in the digest() and hexdigest() methods#9751
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:hashlib-digest-overflow

Conversation

serhiy-storchaka commented Oct 7, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

for the SHAKE algorithm in the hashlib module.

https://bugs.python.org/issue34922

bpo-34922: Fixed integer overflow in the digest() and hexdigest() met…
8e692bb 
…hods

for the SHAKE algorithm in the hashlib module.
serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Oct 7, 2018

ned-deily commented Oct 7, 2018

Copy link
Copy Markdown
Member

@serhiy-storchaka, I'm not interested in a change for master as there is no rush for that so I'm removing myself as a reviewer. I'll let you all figure out what's best. My concern is for 3.6 where something is needed and for 3.7. Is a change like this needed for 3.7 as long as PR 8581 remains in 3.7?

ned-deily removed their request for review October 7, 2018 19:13

serhiy-storchaka commented Oct 7, 2018

Copy link
Copy Markdown
Member Author

A change like this is needed for 3.7 in any case, independently from the fate of #8581. Just crashes can be caused by different input values.

serhiy-storchaka merged commit 9b8c2e7 into python:master Oct 11, 2018

miss-islington commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

serhiy-storchaka deleted the hashlib-digest-overflow branch October 11, 2018 04:41

miss-islington commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9b8c2e767643256202bb11456ba8665593b9a500 3.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2018
bpo-34922: Fix integer overflow in the digest() and hexdigest() metho…
6c5d06a 
…ds (pythonGH-9751)

for the SHAKE algorithm in the hashlib module.
(cherry picked from commit 9b8c2e7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot commented Oct 11, 2018

Copy link
Copy Markdown

GH-9797 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 11, 2018
[3.7] bpo-34922: Fix integer overflow in the digest() and hexdigest()…
4b363b9 
… methods (pythonGH-9751)

for the SHAKE algorithm in the hashlib module..
(cherry picked from commit 9b8c2e7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-bot commented Oct 11, 2018

Copy link
Copy Markdown

GH-9798 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit that referenced this pull request Oct 11, 2018
[3.7] bpo-34922: Fix integer overflow in the digest() and hexdigest()…
8b040e5 
… methods (GH-9751) (GH-9798)

for the SHAKE algorithm in the hashlib module.
(cherry picked from commit 9b8c2e7)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2018
[3.7] bpo-34922: Fix integer overflow in the digest() and hexdigest()…
ffec90b 
… methods (pythonGH-9751) (pythonGH-9798)

for the SHAKE algorithm in the hashlib module.
(cherry picked from commit 9b8c2e7)
(cherry picked from commit 8b040e5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka commented Oct 11, 2018

Copy link
Copy Markdown
Member Author

GH-9801 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka removed their assignment Oct 11, 2018
serhiy-storchaka added a commit that referenced this pull request Oct 11, 2018
[3.6] bpo-34922: Fix integer overflow in the digest() and hexdigest()…
69e6ad6 
… methods (GH-9751) (GH-9798) (GH-9801)

for the SHAKE algorithm in the hashlib module.
(cherry picked from commit 9b8c2e7)
(cherry picked from commit 8b040e5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tiran Awaiting requested review from tiran
vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL