FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-97588: Failing tests to demonstrate the issue by matthiasgoergens · Pull Request #97589 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-97588: Failing tests to demonstrate the issue - #97589

Closed
matthiasgoergens wants to merge 18 commits into
python:mainfrom
matthiasgoergens:bitfields
ConversationCommits (18)ChecksFiles changed
Closed

gh-97588: Failing tests to demonstrate the issue#97589
matthiasgoergens wants to merge 18 commits into
python:mainfrom
matthiasgoergens:bitfields

Conversation

matthiasgoergens commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

The tests are expected to fail, and are marked as such.

bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 27, 2022
matthiasgoergens changed the title gh-97588: Some tests to demonstrate the issue gh-97588: Failing tests to demonstrate the issue Sep 30, 2022

matthiasgoergens commented Sep 30, 2022

Copy link
Copy Markdown
Contributor Author

@mdickinson I marked the tests as failing, so we cant potentially get them into main as a basis for further work.

nanjekyejoannah reviewed Oct 6, 2022
View reviewed changes

nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Shouldn't we be patching a fix instead? Unless we are accepting this as desired behaviour.

matthiasgoergens commented Oct 6, 2022

Copy link
Copy Markdown
Contributor Author

@nanjekyejoannah See #97702 for the fix.

nanjekyejoannah reviewed Oct 7, 2022
View reviewed changes

nanjekyejoannah left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Then we close this to merge the fix instead, no?

matthiasgoergens commented Oct 8, 2022

Copy link
Copy Markdown
Contributor Author

@nanjekyejoannah I'm not completely confident in the fix, yet. But I am confident that these test cases are good.

Not sure we have a general policy against contributing failing test cases?

nanjekyejoannah reviewed Oct 11, 2022
View reviewed changes

nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The tests test the failing caes. But with the fix, these tests will change i.e not failing, I would prefer reviewing a PR with a fix and updated tests, since there is a fix. What do you think?

matthiasgoergens commented Oct 11, 2022

Copy link
Copy Markdown
Contributor Author

@nanjekyejoannah Feel free to review #97702

bedevere-bot mentioned this pull request Mar 14, 2023
Closed

encukou commented Aug 26, 2024

Copy link
Copy Markdown
Member

These were merged with #97702. Thank you!

encukou closed this Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nanjekyejoannah nanjekyejoannah left review comments

Assignees

No one assigned

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL