FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-96670: Raise SyntaxError when parsing NULL bytes by pablogsal · Pull Request #97594 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-96670: Raise SyntaxError when parsing NULL bytes - #97594

Merged
pablogsal merged 1 commit into
python:mainfrom
pablogsal:gh-96670
Sep 27, 2022
ConversationCommits (1)ChecksFiles changed
Merged

gh-96670: Raise SyntaxError when parsing NULL bytes#97594
pablogsal merged 1 commit into
python:mainfrom
pablogsal:gh-96670

Conversation

pablogsal commented Sep 27, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

pablogsal force-pushed the gh-96670 branch 5 times, most recently from 97a8f83 to cb89392 Compare September 27, 2022 12:25
gvanrossum reviewed Sep 27, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What's up with python3.12.abi.new having 22,644 additions?

gvanrossum reviewed Sep 27, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LG except for one word in an error message, I think.

Comment thread Parser/tokenizer.c Outdated

pablogsal commented Sep 27, 2022

Copy link
Copy Markdown
Member Author

What's up with python3.12.abi.new having 22,644 additions?

Wow, that's some error. Let me clean that up

lysnikolaou reviewed Sep 27, 2022
View reviewed changes
Comment thread Objects/fileobject.c
pythongh-96670: Raise SyntaxError when parsing NULL bytes
e10909d 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>

gvanrossum commented Sep 27, 2022

Copy link
Copy Markdown
Member

Ugh, force-push. :-(

gvanrossum reviewed Sep 27, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I see nothing else wrong, let's wait for Lysandros' LGTM.

lysnikolaou approved these changes Sep 27, 2022
View reviewed changes

lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM as well!

mdboom commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

I was going to ask "doesn't this break things for encodings where NULLs are normal, like UTF-16", but then realized we never supported that anyway:

PEP 253: "It does not include encodings which use two or more bytes for all characters like e.g. UTF-16. The reason for this is to keep the encoding detection algorithm in the tokenizer simple."

In that sense, we get a better error message for UTF-16 files with this PR than before. Prior, it would silently fail (behave as if an empty file), and with this PR:

  File "x.py", line 1
    #
SyntaxError: source code cannot contain null bytes

pablogsal merged commit aab01e3 into python:main Sep 27, 2022
pablogsal deleted the gh-96670 branch September 27, 2022 22:23

pablogsal commented Sep 27, 2022

Copy link
Copy Markdown
Member Author

Landing, thank you everyone for your great review and comments! And also thank @mdboom for checking the UTF-16, that was a good consideration :)

P.S. Sorry for the force push :S

vstinner mentioned this pull request Sep 28, 2022
Closed
bskinn mentioned this pull request Apr 24, 2023
Closed
lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request May 5, 2023
[3.11] pythongh-96670: Raise SyntaxError when parsing NULL bytes (pyt…
e6d28ba 
…honGH-97594).

(cherry picked from commit aab01e3)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

bedevere-bot commented May 5, 2023

Copy link
Copy Markdown

GH-104195 is a backport of this pull request to the 3.11 branch.

pablogsal pushed a commit that referenced this pull request May 7, 2023
[3.11] gh-96670: Raise SyntaxError when parsing NULL bytes (GH-97594) (…
a09d390 
…#104195)
mkniewallner mentioned this pull request Jun 18, 2023
Merged
1 of 4 tasks
bdraco mentioned this pull request May 12, 2024
Closed
This was referenced Jul 30, 2024
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum left review comments
lysnikolaou lysnikolaou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL