FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-94808: [coverage] Add an asynchronous generator test by zhanpon · Pull Request #97672 · python/cpython · GitHub

/ cpython Public

gh-94808: [coverage] Add an asynchronous generator test - #97672

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
zhanpon:improve-asyncgen-coverage
Nov 24, 2022
ConversationCommits (2)ChecksFiles changed
Merged

gh-94808: [coverage] Add an asynchronous generator test#97672
kumaraditya303 merged 2 commits into
python:mainfrom
zhanpon:improve-asyncgen-coverage

Conversation

zhanpon commented Sep 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

The test covers the following code path:

cpython/Objects/genobject.c

Lines 1780 to 1785 in ff54dd9

if (o->ags_gen->ag_running_async) {
PyErr_SetString(
PyExc_RuntimeError,
"anext(): asynchronous generator is already running");
return NULL;
}

[coverage] Add an asynchronous generator test
8ce148e 
Cover the error condition of 'asynchronous generator is already running'
bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 30, 2022

mdboom commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

Thanks for improving our test coverage! Can you point to the specific lines that this adds coverage for?

zhanpon commented Sep 30, 2022

Copy link
Copy Markdown
Contributor Author

@mdboom Thank you for the comment! I've added it to the PR description.

bedevere-bot mentioned this pull request Nov 24, 2022
Open
kumaraditya303 merged commit 5f4ae86 into python:main Nov 24, 2022

kumaraditya303 commented Nov 24, 2022

Copy link
Copy Markdown
Contributor

Thanks.

zhanpon deleted the improve-asyncgen-coverage branch November 24, 2022 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 kumaraditya303 approved these changes
iritkatriel Awaiting requested review from iritkatriel

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL