FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98250: Improve documentation about change to Enum.__format__ by mdboom · Pull Request #98261 · python/cpython · GitHub

/ cpython Public

gh-98250: Improve documentation about change to Enum.__format__ - #98261

Closed
mdboom wants to merge 2 commits into
python:mainfrom
mdboom:strenum-info
Closed

gh-98250: Improve documentation about change to Enum.__format__#98261
mdboom wants to merge 2 commits into
python:mainfrom
mdboom:strenum-info

Conversation

mdboom commented Oct 14, 2022
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 14, 2022
mdboom added needs backport to 3.11 only security fixes and removed docs Documentation in the Doc dir labels Oct 14, 2022
mdboom requested a review from ethanfurman October 14, 2022 14:26
Comment thread Doc/whatsnew/3.11.rst Outdated

* ``EnumMeta`` renamed to ``EnumType`` (``EnumMeta`` kept as alias).

* The output of ``Enum.__format__`` has changed to include both the enum name

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Might be worth adding explicitly that this affects enums included in f-strings, since that may not be obvious to a lot of readers.

Copy link
Copy Markdown
Member

Hey, I missed seeing this before I submitted #98295 , but it turns out I noticed a similar issue, as the What's New was not entirely clear on that point, and had already made some enhancements in that regard. I went ahead and made some further improvements and expansions there to more comprehensively address #98250 and incorporate the intent of the changes here, alongside @JelleZijlstra 's suggestion and a number of additional fixes and clarifications.

As that PR essentially rewrites that section and will thus conflict with this one, which I'm still not sure is quite right (as ReprEnum appears to do something quite different from the old __format__ behavior, and there are also still a few smaller points of confusion here), my suggestion would be to consolidate on that one (especially since we don't have much time left before the release), and I'd welcome your review and suggestions over there.

mdboom commented Oct 17, 2022

Copy link
Copy Markdown
Contributor Author

Closing in favor of the more comprehensive #98295.

mdboom closed this Oct 17, 2022
mdboom deleted the strenum-info branch December 22, 2022 15:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL