FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98456: Replace deprecated `set-output` with up-to-date version by noamcohen97 · Pull Request #98457 · python/cpython · GitHub

/ cpython Public

gh-98456: Replace deprecated set-output with up-to-date version - #98457

Merged
corona10 merged 1 commit into
python:mainfrom
noamcohen97:gha-output
Oct 23, 2022
ConversationCommits (1)ChecksFiles changed
Merged

gh-98456: Replace deprecated set-output with up-to-date version#98457
corona10 merged 1 commit into
python:mainfrom
noamcohen97:gha-output

Conversation

noamcohen97 commented Oct 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

noamcohen97 marked this pull request as ready for review October 19, 2022 17:52
sobolevn approved these changes Oct 22, 2022
View reviewed changes

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am already using this in my other projects!
Thank you.

corona10 approved these changes Oct 23, 2022
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

corona10 merged commit 1db2a0c into python:main Oct 23, 2022
corona10 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 23, 2022

miss-islington commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Thanks @noamcohen97 for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Thanks @noamcohen97 for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Sorry, @noamcohen97 and @corona10, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1db2a0cb20a1de5231a73fc7381056d725e90535 3.10

miss-islington commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Sorry @noamcohen97 and @corona10, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 1db2a0cb20a1de5231a73fc7381056d725e90535 3.11

AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Oct 23, 2022

miss-islington commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Thanks @noamcohen97 for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Sorry, @noamcohen97 and @corona10, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1db2a0cb20a1de5231a73fc7381056d725e90535 3.11

corona10 pushed a commit to corona10/cpython that referenced this pull request Oct 23, 2022
[3.10] pythongh-98456: Replace deprecated set-output with up-to-dat…
87f1114 
…e version (pythongh-98457).

(cherry picked from commit 1db2a0c)

Co-authored-by: Noam Cohen <noam@noam.me>
corona10 mentioned this pull request Oct 23, 2022
Merged

bedevere-bot commented Oct 23, 2022

Copy link
Copy Markdown

GH-98564 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 23, 2022
corona10 mentioned this pull request Oct 23, 2022
Merged

bedevere-bot commented Oct 23, 2022

Copy link
Copy Markdown

GH-98565 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 23, 2022
corona10 pushed a commit to corona10/cpython that referenced this pull request Oct 23, 2022
[3.11] pythongh-98456: Replace deprecated set-output with up-to-dat…
0c79a2c 
…e version (pythongh-98457).

(cherry picked from commit 1db2a0c)

Co-authored-by: Noam Cohen <noam@noam.me>
corona10 added a commit that referenced this pull request Oct 25, 2022
[3.10] gh-98456: Replace deprecated set-output with up-to-date vers… (
25eae0b 
gh-98564)

[3.10] gh-98456: Replace deprecated `set-output` with up-to-date version (gh-98457).
(cherry picked from commit 1db2a0c)

Co-authored-by: Noam Cohen <noam@noam.me>

Co-authored-by: Noam Cohen <noam@noam.me>
corona10 added a commit that referenced this pull request Oct 25, 2022
[3.11] gh-98456: Replace deprecated set-output with up-to-date vers… (
5fb3b61 
gh-98565)

[3.11] gh-98456: Replace deprecated `set-output` with up-to-date version (gh-98457).
(cherry picked from commit 1db2a0c)

Co-authored-by: Noam Cohen <noam@noam.me>

Co-authored-by: Noam Cohen <noam@noam.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sobolevn sobolevn approved these changes
corona10 corona10 approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL