FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-98407: fix `test_kill_issue43884` to not leak child processes by kumaraditya303 · Pull Request #98491 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

GH-98407: fix test_kill_issue43884 to not leak child processes - #98491

Merged
gvanrossum merged 3 commits into
python:mainfrom
kumaraditya303:pg
Oct 24, 2022
ConversationCommits (3)ChecksFiles changed
Merged

GH-98407: fix test_kill_issue43884 to not leak child processes #98491
gvanrossum merged 3 commits into
python:mainfrom
kumaraditya303:pg

Conversation

kumaraditya303 commented Oct 20, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 20, 2022
kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 20, 2022

bedevere-bot commented Oct 20, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 65ed5bf 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 20, 2022
gvanrossum mentioned this pull request Oct 20, 2022
Closed
gvanrossum reviewed Oct 20, 2022
View reviewed changes
Comment thread Lib/test/test_asyncio/test_subprocess.py Outdated
kumaraditya303 changed the title GH-98407: use process group in asyncio test_kill_issue43884 GH-98407: fix test_kill_issue43884 to not leak child processes Oct 23, 2022
gvanrossum approved these changes Oct 24, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd like confirmation from the OP (@db3l) that this indeed no longer leaves orphan processes hanging around (for more than 2 seconds :-).

db3l commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

@gvanrossum I can confirm that this PR built locally leaves no processes. I'll also watch for the regular buildbot run post-merge.

gvanrossum merged commit 3b2724a into python:main Oct 24, 2022

miss-islington commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
pythonGH-98407: fix test_kill_issue43884 to not leak child processes (
053dab5 
pythonGH-98491)

(cherry picked from commit 3b2724a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

GH-98613 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 24, 2022
miss-islington added a commit that referenced this pull request Oct 24, 2022
GH-98407: fix test_kill_issue43884 to not leak child processes (GH-…
3a1eb81 
…98491)

(cherry picked from commit 3b2724a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
kumaraditya303 deleted the pg branch October 26, 2022 16:28

vstinner commented Nov 3, 2022

Copy link
Copy Markdown
Member

I don't understand this change.

vstinner commented Nov 3, 2022

Copy link
Copy Markdown
Member

Rationale for sleep 1; sleep 1: #98407 (comment)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL