FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98636: Fix detecting gdbm_compat for _dbm module by mgorny · Pull Request #98643 · python/cpython · GitHub

/ cpython Public

gh-98636: Fix detecting gdbm_compat for _dbm module - #98643

Merged
erlend-aasland merged 1 commit into
python:mainfrom
mgorny:gdbm_compat-98636
Jan 11, 2023
ConversationCommits (1)ChecksFiles changed
Merged

gh-98636: Fix detecting gdbm_compat for _dbm module#98643
erlend-aasland merged 1 commit into
python:mainfrom
mgorny:gdbm_compat-98636

Conversation

mgorny commented Oct 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix the gdbm_compat library detection logic to actually check for
-lgdbm_compat independently of the ndbm detection. This fixes the build
failure with --with-dbmliborder=gdbm, and implicit fallback to ndbm
with the default value.

mgorny force-pushed the gdbm_compat-98636 branch from 896c212 to 894ada5 Compare October 25, 2022 10:28
mgorny force-pushed the gdbm_compat-98636 branch from 894ada5 to 72a9700 Compare October 25, 2022 12:03

mgorny commented Nov 4, 2022

Copy link
Copy Markdown
Contributor Author

Ping.

mgorny commented Dec 7, 2022

Copy link
Copy Markdown
Contributor Author

Another ping. It would be really nice to have this fixed.

bedevere-bot mentioned this pull request Dec 18, 2022
Closed
erlend-aasland reviewed Dec 28, 2022
View reviewed changes
Comment thread configure.ac Outdated
pythongh-98636: Fix detecting gdbm_compat for _dbm module
15510e8 
Fix the gdbm_compat library detection logic to actually check for
-lgdbm_compat independently of the ndbm detection.  This fixes the build
failure with `--with-dbmliborder=gdbm`, and implicit fallback to ndbm
with the default value.

mgorny commented Dec 31, 2022

Copy link
Copy Markdown
Contributor Author

@erlend-aasland, updated as requested.

erlend-aasland commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Does this need a backport?

mgorny commented Jan 11, 2023

Copy link
Copy Markdown
Contributor Author

Does this need a backport?

Unless I'm mistaken, no. The issue was introduced in ec5e253, and FWICS this in 3.12 only.

thesamesam mentioned this pull request Jan 11, 2023
Merged
erlend-aasland merged commit 02a72f0 into python:main Jan 11, 2023

erlend-aasland commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Thanks, and sorry for the delay!

If you want to pursue the AC refactorings discussed, please open an issue/PR.

mgorny commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

Thank you! I'm happy enough having the immediate problem fixed.

mgorny deleted the gdbm_compat-98636 branch January 12, 2023 06:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL