gh-98703: add tests for closing _ProactorSocketTransport with proactor event loop - #98730
Merged
Fidget-Spinner merged 2 commits intoOct 27, 2022
Merged
Conversation
kumaraditya303
force-pushed
the
proactor-test
branch
from
c8ec7e6 to
51ffb5d
Compare
October 26, 2022 16:19
Copy link
Copy Markdown
Member
|
Skip news because it shares the same news item as #98704. |
Sorry, something went wrong.
kumaraditya303
marked this pull request as ready for review
October 27, 2022 02:50
kumaraditya303
requested review from
1st1,
asvetlov and
gvanrossum
as code owners
October 27, 2022 02:50
Fidget-Spinner
approved these changes
Oct 27, 2022
Copy link
Copy Markdown
Member
|
These are great tests. It seems that they failed on every platform prior to the fix :)! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @kumaraditya303 for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-98755 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 27, 2022
… proactor event loop (pythonGH-98730) (cherry picked from commit 96ae80f) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-98756 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 27, 2022
… proactor event loop (pythonGH-98730) (cherry picked from commit 96ae80f) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
gvanrossum
pushed a commit
to gvanrossum/cpython
that referenced
this pull request
Oct 28, 2022
… proactor event loop (pythonGH-98730)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.