FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] gh-98706: Sync with importlib_metadata 4.13.0. by jaraco · Pull Request #98875 · python/cpython · GitHub

/ cpython Public

[3.11] gh-98706: Sync with importlib_metadata 4.13.0. - #98875

Merged
miss-islington merged 4 commits into
python:3.11from
jaraco:bpo-98706
Nov 5, 2022
ConversationCommits (4)ChecksFiles changed
Merged

[3.11] gh-98706: Sync with importlib_metadata 4.13.0.#98875
miss-islington merged 4 commits into
python:3.11from
jaraco:bpo-98706

Conversation

jaraco commented Oct 30, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

These changes are already applied to main but have been selected from importlib_metadata 4.x for their bug fixes.

Automerge-Triggered-By: GH:jaraco

jaraco changed the title [3.11] bpo-98706: Sync with importlib_metadata 4.13.0. [3.11] gh-98706: Sync with importlib_metadata 4.13.0. Oct 30, 2022
jaraco added a commit to python/importlib_metadata that referenced this pull request Oct 30, 2022
Update compatibility matrix to reflect 4.13 in 3.11 (python/cpython#9…
88ad39d 
…8875).
jaraco mentioned this pull request Oct 30, 2022
Merged
jaraco requested a review from pablogsal October 30, 2022 18:10

pablogsal commented Oct 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Hummm, aren't the changes in #93259 technically backwards incompatible? (Nevermind, I think not raising ValueError is likely a bug).

If I am reading https://github.com/python/importlib_metadata/pull/397/files that is technically a new feature which I don't think we can backport but I may be very well misreading it or missing something (so apologies if that's the case). If you think the lack of compatibility with PathDistributions is a bugfix we can backport it (although it would be great if some importlib expert checks the PR as well).

pablogsal approved these changes Oct 31, 2022
View reviewed changes

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

I would like to clarify if there is any risk on the backport before landing (I left a comment).

jaraco commented Nov 5, 2022

Copy link
Copy Markdown
Member Author

Thanks for the review.

If I am reading https://github.com/python/importlib_metadata/pull/397/files that is technically a new feature which I don't think we can backport but I may be very well misreading it or missing something (so apologies if that's the case). If you think the lack of compatibility with PathDistributions is a bugfix we can backport it (although it would be great if some importlib expert checks the PR as well).

I agree. Now that I look at #397 again, I realize I'd intended for the changes there to be isolated to the backport. They shouldn't have made it into this PR. That is, _py39compat shouldn't exist in stdlib. And indeed, that's what's happened. Looking at python/importlib_metadata@3e52430 (the merge commit into the cpython branch of importlib_metadata), the only changes from 4.13 are the type annotations and there's no hint of _py39compat in this PR.

miss-islington merged commit 07734a4 into python:3.11 Nov 5, 2022
jaraco mentioned this pull request Nov 5, 2022
Closed
jaraco deleted the bpo-98706 branch November 26, 2022 14:52
clrpackages pushed a commit to clearlinux-pkgs/pypi-importlib_metadata that referenced this pull request Nov 29, 2022
pypi-importlib_metadata: Autospec creation for update from version 5.…
44030e2 
…0.0 to version 5.1.0

Jason R. Coombs (16):
      Indicate to use latest Python version (workaround for readthedocs/readthedocs.org/#9623). Requires also specifying the OS version (workaround for readthedocs/readthedocs.org#9635).
      Simply wrap .matches instead of replacing EntryPoint.
      Add minimum retention of DeprecatedTuple. Ref #409, Ref #348.
      Fix warning in plural of Import Package.
      Correct syntax is without the space.
      GHA pretty env (#67)
      Add row for Python 3.12 to compatibility map.
      Update compatibility matrix to reflect 4.13 in 3.11 (python/cpython#98875).
      Python 3.10 is synced mainly through 4.6 (plus bugfixes).
      Pin mypy to '<0.990' due to realpython/pytest-mypy#141
      Remove the hyperlink for the Python versions badge. The PyPI badge is a better anchor for the hyperlink.
      Apply explicit_package_bases for mypy and unpin the version. Ref python/mypy#14057.
      Add Python 3.12 to matrix. Only test 3.8-3.10 on Linux.
      Disable flake8 on Python 3.12. Workaround for tholo/pytest-flake8#87.
      Update changelog.
      Add note to docs about limitation of packages_distributions. Fixes #402.

Julien Palard (1):
      Doc: missing underscore in hyperlink. (GH-98391)

Zach Burnett (1):
      rename `.readthedocs.yml` to `.readthedocs.yaml` (RTD docs indicate that `.readthedocs.yml` will be deprecated) (#68)

layday (1):
      Fix `SimplePath` protocol

stratakis commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

This change seems to have introduced a possible regression on the Fedora setuptools builds.

Details: pypa/setuptools#3761

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL