FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-93357: Port test_pep492 to IsolatedAsyncioTestCase by arhadthedev · Pull Request #98877 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-93357: Port test_pep492 to IsolatedAsyncioTestCase - #98877

Closed
arhadthedev wants to merge 2 commits into
python:mainfrom
arhadthedev:utilsTestCase-pep492
ConversationCommits (2)ChecksFiles changed
Closed

gh-93357: Port test_pep492 to IsolatedAsyncioTestCase#98877
arhadthedev wants to merge 2 commits into
python:mainfrom
arhadthedev:utilsTestCase-pep492

Conversation

arhadthedev commented Oct 30, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This attempt makes way less changes so it shouldn't fail random tests with races.

bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 30, 2022
bedevere-bot mentioned this pull request Mar 22, 2023
Closed
21 tasks

arhadthedev commented Apr 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Closing this PR because:

  1. I have no expertise or experience to determine whether another failure of already flaky test_asyncio is caused by my changes (and thus needs to be urgently investigated)
  2. The volume of changes is way larger than I initially expected;
  3. @kumaraditya303 will port essential tests anyway.

arhadthedev deleted the utilsTestCase-pep492 branch April 19, 2023 10:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 Awaiting requested review from 1st1 1st1 will be requested when the pull request is marked ready for review 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov will be requested when the pull request is marked ready for review asvetlov is a code owner
kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 will be requested when the pull request is marked ready for review kumaraditya303 is a code owner
willingc Awaiting requested review from willingc willingc will be requested when the pull request is marked ready for review willingc is a code owner

Assignees

No one assigned

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL