FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98931: Improve error message when the user types 'import x from y' instead of 'from y import x' by pablogsal · Pull Request #98932 · python/cpython · GitHub

/ cpython Public

gh-98931: Improve error message when the user types 'import x from y' instead of 'from y import x' - #98932

Merged
pablogsal merged 4 commits into
python:mainfrom
pablogsal:gh-98931
Nov 1, 2022
ConversationCommits (4)ChecksFiles changed
Merged

gh-98931: Improve error message when the user types 'import x from y' instead of 'from y import x'#98932
pablogsal merged 4 commits into
python:mainfrom
pablogsal:gh-98931

Conversation

pablogsal commented Oct 31, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Oct 31, 2022
Closed
lysnikolaou reviewed Oct 31, 2022
View reviewed changes

lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good one! Just one suggestion for the error message.

Comment thread Grammar/python.gram Outdated
RAISE_SYNTAX_ERROR_KNOWN_LOCATION(a, "cannot use double starred expression here") }
invalid_import:
| a='import' dotted_name 'from' dotted_name {
RAISE_SYNTAX_ERROR_STARTING_FROM(a, "Did you meant to use 'from ... import ...' instead?") }

lysnikolaou Oct 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ditto in tests and docs.

Suggested change
RAISE_SYNTAX_ERROR_STARTING_FROM(a, "Did you meant to use 'from ... import ...' instead?") }
RAISE_SYNTAX_ERROR_STARTING_FROM(a, "Did you mean to use 'from ... import ...' instead?") }

pablogsal Oct 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done! Thanks for the review :)

lysnikolaou Oct 31, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Of course! I think you missed the one in whatsnew?

pablogsal commented Oct 31, 2022

Copy link
Copy Markdown
Member Author

Will fix the doctest tomorrow

CharlieZhao95 reviewed Nov 1, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst
Update Doc/whatsnew/3.12.rst
9f705af 
Co-authored-by: Charlie Zhao <zhaoyu_hit@qq.com>
lysnikolaou approved these changes Nov 1, 2022
View reviewed changes

lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Go!

pablogsal merged commit 395d428 into python:main Nov 1, 2022
pablogsal deleted the gh-98931 branch November 1, 2022 13:01

pablogsal commented Nov 1, 2022

Copy link
Copy Markdown
Member Author

🚀

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lysnikolaou lysnikolaou approved these changes
+1 more reviewer
CharlieZhao95 CharlieZhao95 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve syntax error for invalid imports

4 participants

Back | FazBrowse Home | New Git URL