FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-92871: Postpone the removal of typing.{io,re} to 3.13 by srittau · Pull Request #98958 · python/cpython · GitHub

/ cpython Public

gh-92871: Postpone the removal of typing.{io,re} to 3.13 - #98958

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
srittau:typing-removals
Nov 2, 2022
ConversationCommits (1)ChecksFiles changed
Merged

gh-92871: Postpone the removal of typing.{io,re} to 3.13#98958
JelleZijlstra merged 1 commit into
python:mainfrom
srittau:typing-removals

Conversation

srittau commented Nov 1, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

See #92873 for background. Cc @JelleZijlstra

Needs backport to Python 3.9+.

bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 1, 2022
srittau changed the title gh-92873: Postpone the removal of typing.{io,re} gh-92871: Postpone the removal of typing.{io,re} Nov 1, 2022
bedevere-bot mentioned this pull request Nov 1, 2022
Closed

AlexWaygood commented Nov 1, 2022

Copy link
Copy Markdown
Member

Needs backport to Python 3.9+.

3.9 is now only receiving security-related updates, so we'll probably only be backporting to 3.10 and 3.11 :)

AlexWaygood commented Nov 1, 2022

Copy link
Copy Markdown
Member

We should probably also remove this line from the "What's New in Python 3.11" page:

cpython/Doc/whatsnew/3.11.rst

Line 1853 in 4564490

* The :class:`typing.io <typing.IO>` namespace

But maybe it would be better to do that in a separate PR, so that this one backports to 3.10 cleanly.

AlexWaygood added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 1, 2022
AlexWaygood changed the title gh-92871: Postpone the removal of typing.{io,re} gh-92871: Postpone the removal of typing.{io,re} to 3.13 Nov 1, 2022
gvanrossum removed their request for review November 1, 2022 17:44
JelleZijlstra merged commit 65d1407 into python:main Nov 2, 2022

miss-islington commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @srittau for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2022
pythongh-92871: Postpone the removal of typing.{io,re} to 3.13 (pytho…
07be05c 
…nGH-98958)

(cherry picked from commit 65d1407)

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>

miss-islington commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, @srittau and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 65d1407737befc3e9430eda8ae14ab1c7f9d8c7a 3.10

bedevere-bot commented Nov 2, 2022

Copy link
Copy Markdown

GH-98985 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 2, 2022

bedevere-bot commented Nov 2, 2022

Copy link
Copy Markdown

GH-98986 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 2, 2022
miss-islington added a commit that referenced this pull request Nov 2, 2022
gh-92871: Postpone the removal of typing.{io,re} to 3.13 (GH-98958)
b2e28c8 
(cherry picked from commit 65d1407)

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
srittau deleted the typing-removals branch November 2, 2022 07:08
AlexWaygood pushed a commit that referenced this pull request Nov 2, 2022
[3.10] gh-92871: Postpone the removal of typing.{io,re} to 3.13 (GH-9…
e07086d 
…8958) (#98986)

[3.10] gh-92871: Postpone the removal of typing.{io,re} to 3.13 (GH-98958).
(cherry picked from commit 65d1407)

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>

Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
Fidget-Spinner Awaiting requested review from Fidget-Spinner
AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees

JelleZijlstra

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL