FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-98989: configure: add 3.11 to list of Pythons by JelleZijlstra · Pull Request #98988 · python/cpython · GitHub

/ cpython Public

gh-98989: configure: add 3.11 to list of Pythons - #98988

Merged
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:fixconfig
Nov 2, 2022
ConversationCommits (3)ChecksFiles changed
Merged

gh-98989: configure: add 3.11 to list of Pythons#98988
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:fixconfig

Conversation

JelleZijlstra commented Nov 2, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

JelleZijlstra commented Nov 2, 2022

Copy link
Copy Markdown
Member Author

I'll add an issue and NEWS since the bug went out in 3.12a1 and could affect some users.

gvanrossum approved these changes Nov 2, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Don't take my word for it, this is probably up to @tiran or @brettcannon to review.

JelleZijlstra changed the title configure: add 3.11 to list of Pythons gh-98989: configure: add 3.11 to list of Pythons Nov 2, 2022
bedevere-bot mentioned this pull request Nov 2, 2022
Closed
hauntsaninja reviewed Nov 2, 2022
View reviewed changes
Comment thread configure.ac

AC_CHECK_PROGS([PYTHON_FOR_REGEN],
[python$PACKAGE_VERSION python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],
[python$PACKAGE_VERSION python3.11 python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],

hauntsaninja Nov 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Worth queuing up a couple versions?

hugovk commented Nov 2, 2022

Copy link
Copy Markdown
Member

Something to add to PEP 101 (Doing Python Releases)?

kumaraditya303 reviewed Nov 2, 2022
View reviewed changes
Comment thread configure.ac

AC_CHECK_PROGS([PYTHON_FOR_REGEN],
[python$PACKAGE_VERSION python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],
[python$PACKAGE_VERSION python3.11 python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],

kumaraditya303 Nov 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why are we allowing python3.8 and lower in the first place if we know that 3.9+ is required?

erlend-aasland Nov 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If 3.9 or higher is required, we should remove the earlier and incompatible versions.

JelleZijlstra Nov 2, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Guido said he wanted to remove the 3.9+ dependency that crept into one of the scripts. Increasing the minimum required version might need more discussion as it could make bootstrapping harder for some.

kumaraditya303 Nov 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ok sure let's get this in first as this is failing randomly on PRs.

JelleZijlstra Nov 2, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@erlend-aasland any objections to landing this?

erlend-aasland Nov 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nah, good to good for my part :)

erlend-aasland self-assigned this Nov 2, 2022
Update Misc/NEWS.d/next/Build/2022-11-01-21-45-58.gh-issue-98989.tMxb…
3ca0188 
…dB.rst

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
JelleZijlstra mentioned this pull request Nov 2, 2022
Open

JelleZijlstra commented Nov 2, 2022

Copy link
Copy Markdown
Member Author

Something to add to PEP 101 (Doing Python Releases)?

python/peps#2864

JelleZijlstra merged commit f7241aa into python:main Nov 2, 2022
JelleZijlstra deleted the fixconfig branch November 2, 2022 17:05
kumaraditya303 mentioned this pull request Nov 2, 2022
Merged
JelleZijlstra mentioned this pull request Nov 2, 2022
Closed
gvanrossum mentioned this pull request Nov 2, 2022
Closed
erlend-aasland mentioned this pull request May 14, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hauntsaninja hauntsaninja left review comments
erlend-aasland erlend-aasland approved these changes
kumaraditya303 kumaraditya303 left review comments
gvanrossum gvanrossum approved these changes

Assignees

erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL