gh-87092: expose the compiler's codegen to python for unit tests - #99111
gh-87092: expose the compiler's codegen to python for unit tests#99111iritkatriel merged 19 commits into
Conversation
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit a2a1c17 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 3c1c647 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit d98f150 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 00aea64 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit ab3f67c 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
markshannon
left a comment
There was a problem hiding this comment.
This is a nice improvement.
I have a few questions and comments.
Sorry, something went wrong.
|
|
||
| /* Access compiler internals for unit testing */ | ||
|
|
||
| PyAPI_FUNC(PyObject*) _PyCompile_CodeGen( |
There was a problem hiding this comment.
Does this (or the other functions) need to be an API function?
Sorry, something went wrong.
There was a problem hiding this comment.
Can _testinternalcapi import them otherwise?
Sorry, something went wrong.
There was a problem hiding this comment.
I think so, that why it has "internal" in the name.
It defines Py_BUILD_CORE_BUILTIN
Sorry, something went wrong.
There was a problem hiding this comment.
It doesn't seem to work:
[ERROR] _testinternalcapi failed to import: dlopen(/Users/iritkatriel/src/cpython-654/build/lib.macosx-13.0-x86_64-3.12-pydebug/_testinternalcapi.cpython-312d-darwin.so, 0x0002): symbol not found in flat namespace '__PyCompile_CodeGen'
Sorry, something went wrong.
There was a problem hiding this comment.
I'll merge this PR now, it's getting into merge conflicts all the time. We can remove these from the API later if it's possible.
Sorry, something went wrong.
With this we can run just codegen from python, and get the un-optimized instruction sequence for an AST.