FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-99103: Normalize specialized traceback anchors against the current line by isidentical · Pull Request #99145 · python/cpython · GitHub

/ cpython Public

gh-99103: Normalize specialized traceback anchors against the current line - #99145

Merged
miss-islington merged 2 commits into
python:mainfrom
isidentical:gh-99103
Nov 12, 2022
ConversationCommits (2)ChecksFiles changed
Merged

gh-99103: Normalize specialized traceback anchors against the current line#99145
miss-islington merged 2 commits into
python:mainfrom
isidentical:gh-99103

Conversation

isidentical commented Nov 5, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Nov 5, 2022
Closed
isidentical added the needs backport to 3.11 only security fixes label Nov 5, 2022
pablogsal reviewed Nov 8, 2022
View reviewed changes
Comment thread Python/traceback.c Outdated
pablogsal reviewed Nov 8, 2022
View reviewed changes
Comment thread Python/traceback.c
pablogsal reviewed Nov 8, 2022
View reviewed changes
Comment thread Lib/traceback.py Outdated
pablogsal reviewed Nov 8, 2022
View reviewed changes
Comment thread Lib/traceback.py Outdated
pablogsal approved these changes Nov 8, 2022
View reviewed changes

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

I left a bunch of small nits. Thanks for fixing this :)

isidentical commented Nov 12, 2022

Copy link
Copy Markdown
Member Author

Thank you @pablogsal, they all should be addressed now!

miss-islington commented Nov 12, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.

miss-islington merged commit 57be545 into python:main Nov 12, 2022

miss-islington commented Nov 12, 2022

Copy link
Copy Markdown
Contributor

Thanks @isidentical for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Nov 12, 2022

Copy link
Copy Markdown
Contributor

Sorry, @isidentical, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 57be5459593bbd09583317ebdafc4d58ae51dbf4 3.11

miss-islington self-assigned this Nov 12, 2022
isidentical added a commit to isidentical/cpython that referenced this pull request Nov 12, 2022
[3.11] pythongh-99103: Normalize specialized traceback anchors agains…
d946e7a 
…t the current line (pythonGH-99145)

Automerge-Triggered-By: GH:isidentical.
(cherry picked from commit 57be545)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
pablogsal pushed a commit that referenced this pull request Nov 21, 2022
[3.11] gh-99103: Normalize specialized traceback anchors against the …
a3480ec 
…current line (#99423)

[3.11] gh-99103: Normalize specialized traceback anchors against the current line (GH-99145)

Automerge-Triggered-By: GH:isidentical.
(cherry picked from commit 57be545)

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
terryjreedy removed the needs backport to 3.11 only security fixes label Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal pablogsal approved these changes
iritkatriel Awaiting requested review from iritkatriel
ammaraskar Awaiting requested review from ammaraskar

Assignees

miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL