gh-99204: Calculate base_executable by alternate names in POSIX venvs by vfazio · Pull Request #99206 · python/cpython · GitHub

Check to see if base_executable exists. If it does not, attempt to use known alternative names of the python binary to find an executable in the path specified by home.

If no alternative is found, previous behavior is preserved.

Issue: sys._base_executable may not exist on posix venvs made with --copies #99204

I think this is a reasonable fix, but let's see if others agree.

Conceptually it seems fine. Not sure whether we should mark this a "QUIRK" and aim to resolve it in some other way? I'll leave that to the POSIX people to decide

… venvs Check to see if `base_executable` exists. If it does not, attempt to use known alternative names of the python binary to find an executable in the path specified by `home`. If no alternative is found, previous behavior is preserved. Signed-off-by: Vincent Fazio <vfazio@gmail.com>

Please don't force push changes when doing PRs. We'll squash merge at the end, but for now I have to re-review from the start because the diff is broken.

I don't have time for that right now, but if someone else signs off and the variable names are indeed fixed, they can merge.

Please don't force push changes when doing PRs. We'll squash merge at the end, but for now I have to re-review from the start because the diff is broken.

I don't have time for that right now, but if someone else signs off and the variable names are indeed fixed, they can merge.

@zooba sorry about that, my mistake completely. Diff below

-                        _base_exe = basename(executable)
-                        for _candidate in (DEFAULT_PROGRAM_NAME, f'python{VERSION_MAJOR}.{VERSION_MINOR}'):
-                            _candidate += EXE_SUFFIX if EXE_SUFFIX else ''
-                            if _base_exe == _candidate:
+                        base_exe = basename(executable)
+                        for candidate in (DEFAULT_PROGRAM_NAME, f'python{VERSION_MAJOR}.{VERSION_MINOR}'):
+                            candidate += EXE_SUFFIX if EXE_SUFFIX else ''
+                            if base_exe == candidate:
                                 continue
-                            _candidate = joinpath(executable_dir, _candidate)
+                            candidate = joinpath(executable_dir, candidate)
                             # Only set base_executable if the candidate exists.
                             # If no candidate succeeds, subsequent errors related to
                             # base_executable (like FileNotFoundError) remain in the
                             # context of the original executable name
-                            if isfile(_candidate):
-                                base_executable = _candidate
+                            if isfile(candidate):
+                                base_executable = candidate
                                 break
             break
     else:

would there be any concerns about me also making a PR targeting 3.11? Fixing it here means not having to work around it in downstream packages.

Thanks @vfazio for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

… venvs (pythonGH-99206) Check to see if `base_executable` exists. If it does not, attempt to use known alternative names of the python binary to find an executable in the path specified by `home`. If no alternative is found, previous behavior is preserved. Signed-off-by: Vincent Fazio <vfazio@gmail.com> (cherry picked from commit c41b13d) Co-authored-by: Vincent Fazio <vfazio@gmail.com> Signed-off-by: Vincent Fazio <vfazio@gmail.com>

GH-99340 is a backport of this pull request to the 3.11 branch.

would there be any concerns about me also making a PR targeting 3.11?

We'll let the bot do it. Should backport fine, as we haven't really been working on anything new in this file

…GH-99206) Check to see if `base_executable` exists. If it does not, attempt to use known alternative names of the python binary to find an executable in the path specified by `home`. If no alternative is found, previous behavior is preserved. Signed-off-by: Vincent Fazio <vfazio@gmail.com> (cherry picked from commit c41b13d) Co-authored-by: Vincent Fazio <vfazio@gmail.com> Signed-off-by: Vincent Fazio <vfazio@gmail.com>

… venvs (pythonGH-99206) Check to see if `base_executable` exists. If it does not, attempt to use known alternative names of the python binary to find an executable in the path specified by `home`. If no alternative is found, previous behavior is preserved. Signed-off-by: Vincent Fazio <vfazio@gmail.com> Signed-off-by: Vincent Fazio <vfazio@gmail.com>

bedevere-bot mentioned this pull request Nov 7, 2022

sys._base_executable may not exist on posix venvs made with --copies #99204

Closed

bedevere-bot added the awaiting review label Nov 7, 2022

FFY00 approved these changes Nov 9, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Nov 9, 2022

FFY00 requested a review from zooba November 9, 2022 03:49

zooba reviewed Nov 9, 2022

View reviewed changes

Comment thread Modules/getpath.py Outdated

vfazio force-pushed the vfazio-base-exec-fallback branch 2 times, most recently from e427dea to 76403d8 Compare November 9, 2022 21:16

vfazio force-pushed the vfazio-base-exec-fallback branch from 76403d8 to 0683b37 Compare November 9, 2022 21:18

vfazio requested a review from zooba November 9, 2022 21:22

zooba merged commit c41b13d into python:main Nov 10, 2022

bedevere-bot removed the awaiting merge label Nov 10, 2022

zooba added the needs backport to 3.11 only security fixes label Nov 10, 2022

bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 10, 2022

gh-99204: Calculate base_executable by alternate names in POSIX venvs by vfazio · Pull Request #99206 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-99204: Calculate base_executable by alternate names in POSIX venvs - #99206

gh-99204: Calculate base_executable by alternate names in POSIX venvs#99206
zooba merged 1 commit into
python:mainfrom
vfazio:vfazio-base-exec-fallback

vfazio commented Nov 7, 2022 •
edited by bedevere-bot
Loading

Uh oh!

Uh oh!

FFY00 left a comment

Uh oh!

Uh oh!

zooba commented Nov 9, 2022

Uh oh!

zooba commented Nov 9, 2022

Uh oh!

vfazio commented Nov 9, 2022

Uh oh!

vfazio commented Nov 9, 2022 •
edited
Loading

Uh oh!

Uh oh!

miss-islington commented Nov 10, 2022

Uh oh!

bedevere-bot commented Nov 10, 2022

Uh oh!

zooba commented Nov 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gh-99204: Calculate base_executable by alternate names in POSIX venvs by vfazio · Pull Request #99206 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-99204: Calculate base_executable by alternate names in POSIX venvs - #99206

gh-99204: Calculate base_executable by alternate names in POSIX venvs#99206zooba merged 1 commit intopython:mainpython/cpython:mainfrom vfazio:vfazio-base-exec-fallbackvfazio/cpython:vfazio-base-exec-fallbackCopy head branch name to clipboard

Conversation

vfazio commented Nov 7, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FFY00 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zooba commented Nov 9, 2022

Uh oh!

zooba commented Nov 9, 2022

Uh oh!

vfazio commented Nov 9, 2022

Uh oh!

vfazio commented Nov 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Nov 10, 2022

Uh oh!

bedevere-bot commented Nov 10, 2022

Uh oh!

zooba commented Nov 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gh-99204: Calculate base_executable by alternate names in POSIX venvs#99206
zooba merged 1 commit into
python:mainfrom
vfazio:vfazio-base-exec-fallback

vfazio commented Nov 7, 2022 •
edited by bedevere-bot
Loading

vfazio commented Nov 9, 2022 •
edited
Loading