gh-99184: Bypass instance attribute access in `repr` of `weakref.ref` by sobolevn · Pull Request #99244 · python/cpython · GitHub

Consider this as a fix proposal :)

Thanks a lot to @MojoVampire for the idea.

Issue: str(weakref) throws error KeyError: '__name__' if the original obj override __getattr__ #99184

…f.ref`

Do we still need it? 🤔

Yes, without it:

Fatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailed
Python runtime state: initialized

Current thread 0x00000001039365c0 (most recent call first):
  File "/Users/sobolev/Desktop/cpython/Lib/test/test_weakref.py", line 116 in test_basic_ref
  File "/Users/sobolev/Desktop/cpython/Lib/unittest/case.py", line 579 in _callTestMethod

You were suggested reviewers :)

Note for reviewers about dynamic __weakref__. One might think that this PR can break existing dynamic __weakref__ assignment. For example:

>>> import weakref
>>> class A: ...
... 
>>> a = A()
>>> w = weakref.ref(a)
>>> a1 = A()
>>> a1.__weakref__
>>> a1.__weakref__ = w
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: attribute '__weakref__' of 'A' objects is not writable

But, as you can see it is not writable. So, it should not affect anything really.
I am going to update the branch and trigget all buildbots, just to be sure.

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit d0aad14 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit d0aad14 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 5ca1917 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

LGTM

Thanks @sobolevn for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

…f.ref` (pythonGH-99244) (cherry picked from commit 58b6be3) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

GH-103789 is a backport of this pull request to the 3.11 branch.

…ef.ref` (GH-99244) (#103789) gh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (GH-99244) (cherry picked from commit 58b6be3) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

* main: (53 commits) pythongh-102498 Clean up unused variables and imports in the email module (python#102482) pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244) pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365) pythongh-94300: Update datetime.strptime documentation (python#95318) pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778) pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456) pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775) Revert "Add tests for empty range equality (python#103751)" (python#103770) pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519) pythonGH-65022: Fix description of copyreg.pickle function (python#102656) pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324) pythongh-91687: modernize dataclass example typing (python#103773) pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747) pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769) pythongh-87452: Improve the Popen.returncode docs Removed unnecessary escaping of asterisks (python#103714) pythonGH-102973: Slim down Fedora packages in the dev container (python#103283) pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095) Add tests for empty range equality (python#103751) pythongh-103712: Increase the length of the type name in AttributeError messages (python#103713) ...

* superopt: (82 commits) pythongh-101517: fix line number propagation in code generated for except* (python#103550) pythongh-103780: Use patch instead of mock in asyncio unix events test (python#103782) pythongh-102498 Clean up unused variables and imports in the email module (python#102482) pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244) pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365) pythongh-94300: Update datetime.strptime documentation (python#95318) pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778) pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456) pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775) Revert "Add tests for empty range equality (python#103751)" (python#103770) pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519) pythonGH-65022: Fix description of copyreg.pickle function (python#102656) pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324) pythongh-91687: modernize dataclass example typing (python#103773) pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747) pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769) pythongh-87452: Improve the Popen.returncode docs Removed unnecessary escaping of asterisks (python#103714) pythonGH-102973: Slim down Fedora packages in the dev container (python#103283) pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095) ...

pythongh-99184 : Bypass instance attribute access in repr of `weakre…

d0aad14

…f.ref`

bedevere-bot mentioned this pull request Nov 8, 2022

str(weakref) throws error KeyError: '__name__' if the original obj override __getattr__ #99184

Closed

bedevere-bot added the awaiting review label Nov 8, 2022

sobolevn commented Nov 8, 2022

View reviewed changes

yanboliang mentioned this pull request Nov 11, 2022

[Dynamo] Fix str(Guard.obj_weakref) bug to re-ennable support overriding __getattr__ pytorch/pytorch#88564

Closed

sobolevn requested review from ericsnowcurrently and iritkatriel December 24, 2022 08:18

Merge branch 'main' into issue-99184

5ca1917

sobolevn added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Mar 27, 2023

bedevere-bot removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Mar 27, 2023

sobolevn added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 27, 2023

bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 27, 2023

carljm approved these changes Mar 29, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Mar 29, 2023

carljm merged commit 58b6be3 into python:main Apr 24, 2023

bedevere-bot removed the awaiting merge label Apr 24, 2023

carljm added the needs backport to 3.11 only security fixes label Apr 24, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 24, 2023

pythongh-99184 : Bypass instance attribute access in repr of `weakre…

29adef0

…f.ref` (pythonGH-99244) (cherry picked from commit 58b6be3) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 24, 2023

gh-99184: Bypass instance attribute access in `repr` of `weakref.ref` by sobolevn · Pull Request #99244 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-99184: Bypass instance attribute access in repr of weakref.ref - #99244

gh-99184: Bypass instance attribute access in repr of weakref.ref#99244
carljm merged 2 commits into
python:mainfrom
sobolevn:issue-99184

sobolevn commented Nov 8, 2022 •
edited by bedevere-bot
Loading

Uh oh!

Uh oh!

sobolevn Nov 8, 2022

Uh oh!

sobolevn Nov 8, 2022

Uh oh!

sobolevn commented Dec 24, 2022

Uh oh!

sobolevn commented Mar 27, 2023 •
edited by AlexWaygood
Loading

Uh oh!

Uh oh!

bedevere-bot commented Mar 27, 2023

Uh oh!

bedevere-bot commented Mar 27, 2023

Uh oh!

bedevere-bot commented Mar 27, 2023

Uh oh!

carljm left a comment

Uh oh!

miss-islington commented Apr 24, 2023

Uh oh!

bedevere-bot commented Apr 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -170,10 +170,7 @@ weakref_repr(PyWeakReference *self)
		}

		Py_INCREF(obj);

gh-99184: Bypass instance attribute access in `repr` of `weakref.ref` by sobolevn · Pull Request #99244 · python/cpython · GitHub

Uh oh!

Uh oh!

gh-99184: Bypass instance attribute access in repr of weakref.ref - #99244

gh-99184: Bypass instance attribute access in repr of weakref.ref#99244carljm merged 2 commits intopython:mainpython/cpython:mainfrom sobolevn:issue-99184sobolevn/cpython:issue-99184Copy head branch name to clipboard

Conversation

sobolevn commented Nov 8, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobolevn Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

sobolevn Nov 8, 2022

Choose a reason for hiding this comment

Uh oh!

sobolevn commented Dec 24, 2022

Uh oh!

sobolevn commented Mar 27, 2023 • edited by AlexWaygood Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Mar 27, 2023

Uh oh!

bedevere-bot commented Mar 27, 2023

Uh oh!

bedevere-bot commented Mar 27, 2023

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Apr 24, 2023

Uh oh!

bedevere-bot commented Apr 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-99184: Bypass instance attribute access in repr of weakref.ref#99244
carljm merged 2 commits into
python:mainfrom
sobolevn:issue-99184

sobolevn commented Nov 8, 2022 •
edited by bedevere-bot
Loading

sobolevn commented Mar 27, 2023 •
edited by AlexWaygood
Loading