FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use faster APIs to calculate paths at startup for Store packaged Python on Windows by zooba · Pull Request #99345 · python/cpython · GitHub

/ cpython Public

Use faster APIs to calculate paths at startup for Store packaged Python on Windows - #99345

Merged
zooba merged 4 commits into
python:mainfrom
zooba:faststart
Nov 23, 2022
ConversationCommits (4)ChecksFiles changed
Merged

Use faster APIs to calculate paths at startup for Store packaged Python on Windows#99345
zooba merged 4 commits into
python:mainfrom
zooba:faststart

Conversation

zooba commented Nov 10, 2022

Copy link
Copy Markdown
Member

These APIs were added in Windows 8, so we can safely backport.

zooba requested a review from a team as a code owner November 10, 2022 20:35

zooba commented Nov 10, 2022

Copy link
Copy Markdown
Member Author

The rough testing I did showed about 50% reduction in startup time (~450ms->250ms) in non-ideal circumstances, but the Windows devs I was working with said it seemed right. The numbers were pretty stable.

zooba commented Nov 10, 2022

Copy link
Copy Markdown
Member Author

Okay, had to retract one of the major optimisations because it can be incorrect. That brings the improvement down to around 50ms, which is still worthwhile, but not as impressive.

However, users can at least override this perf impact by setting their own PYTHONUSERBASE env variable before launching.

zooba commented Nov 10, 2022

Copy link
Copy Markdown
Member Author

It's possible we might be able to bring that optimisation back, looks like Windows covers the concerning edge cases for us. Still checking

zooba added DO-NOT-MERGE performance Performance or resource usage labels Nov 10, 2022
zooba merged commit 71a4a2d into python:main Nov 23, 2022

miss-islington commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

zooba deleted the faststart branch November 23, 2022 19:50

bedevere-bot commented Nov 23, 2022

Copy link
Copy Markdown

GH-99733 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 23, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2022
Use faster APIs to calculate paths at startup for Store packaged Pyth…
bb33c07 
…on on Windows (pythonGH-99345)

(cherry picked from commit 71a4a2d)

Co-authored-by: Steve Dower <steve.dower@python.org>

bedevere-bot commented Nov 23, 2022

Copy link
Copy Markdown

GH-99734 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 23, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2022
Use faster APIs to calculate paths at startup for Store packaged Pyth…
938c667 
…on on Windows (pythonGH-99345)

(cherry picked from commit 71a4a2d)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Nov 23, 2022
Use faster APIs to calculate paths at startup for Store packaged Pyth…
d74117a 
…on on Windows (GH-99345)

(cherry picked from commit 71a4a2d)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Nov 23, 2022
Use faster APIs to calculate paths at startup for Store packaged Pyth…
612834e 
…on on Windows (GH-99345)

(cherry picked from commit 71a4a2d)

Co-authored-by: Steve Dower <steve.dower@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

performance Performance or resource usage skip issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL