Repository navigation
GH-94597: add deprecation warnings for subclassing AbstractChildWatcher - #99386
Merged
gvanrossum merged 3 commits intoNov 12, 2022
Merged
gvanrossum merged 3 commits into
gvanrossum merged 3 commits into
Conversation
kumaraditya303
requested review from
1st1,
asvetlov and
gvanrossum
as code owners
November 11, 2022 17:48
Copy link
Copy Markdown
Contributor
Author
|
This isn't really needed as deprecation warning will be emitted anyway when configuring the child watcher via set_child_watcher but still adding for anyone who is subclassing this but not configuring the child watcher for whatever reason. |
Sorry, something went wrong.
gvanrossum
approved these changes
Nov 11, 2022
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
(Do double check the appearance of the deprecation note.)
Sorry, something went wrong.
Comment thread
Doc/library/asyncio-policy.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.