gh-81057: Generate a Separate Initializer For Each Part of the Global Objects Initializer - #99389
Merged
ericsnowcurrently merged 1 commit intoNov 11, 2022
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ethanfurman
pushed a commit
to ethanfurman/cpython
that referenced
this pull request
Nov 12, 2022
…Global Objects Initializer (pythongh-99389) Up until now we had a single generated initializer macro for all the statically declared global objects in _PyRuntimeState, including several one-offs (e.g. the empty tuple). The one-offs don't need to be generated, but were because we had one big initializer. Having separate initializers for set of generated global objects allows us to generate only the ones we need to. This allows us to add initializers for one-off global objects without having to generate them. python#81057
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we ge have a single generated initializer macro for all the statically declared global objects in _PyRuntimState, including several one-offs (e.g. the empty tuple). The one-offs don't need to be generated, but are because we have one big initializer. Having separate initializers for the different bottom-level groups of global objects allows us to generate only the ones we need to.
This allows us to add initializers for one-off global objects without having to generate them.