FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-99387: Update `pathlib.Path.absolute()` docs to add `versionadded` by Reddragonemperor58 · Pull Request #99416 · python/cpython · GitHub

/ cpython Public

gh-99387: Update pathlib.Path.absolute() docs to add versionadded - #99416

Closed
Reddragonemperor58 wants to merge 4 commits into
python:mainfrom
Reddragonemperor58:my-techdoc-contribution
ConversationCommits (4)ChecksFiles changed
Closed

gh-99387: Update pathlib.Path.absolute() docs to add versionadded#99416
Reddragonemperor58 wants to merge 4 commits into
python:mainfrom
Reddragonemperor58:my-techdoc-contribution

Conversation

Reddragonemperor58 commented Nov 12, 2022

Copy link
Copy Markdown

#99387: committed changes to tech documentation under the path.absolute() function

ghost commented Nov 12, 2022 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 12, 2022
Reddragonemperor58 mentioned this pull request Nov 12, 2022
Closed
AA-Turner reviewed Nov 12, 2022
View reviewed changes
Comment thread Doc/library/pathlib.rst
>>> p.absolute()
PosixPath('/home/antoine/pathlib/tests')

.. versionadded:: 3.11

AA-Turner Nov 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
.. versionadded:: 3.11
.. versionadded:: 3.4

But per Brandt, this likely isn't needed at all.

A

Reddragonemperor58 Nov 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yeah my bad I was committing changes when he posted and I didn't see that but still
@AA-Turner isn't it 3.11?

AA-Turner Nov 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is marked as resolved, though you haven't pushed the change yet -- is this intentional?

A

Reddragonemperor58 Nov 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No i didn't understand the term!
i just clicked on it and was waiting for your reply then I saw it was changed to unresolved;😅
and the resolved thing was trailing whitespaces

Reddragonemperor58 changed the title Updated tech docs as per issue #99387 gh-99387 Updated tech docs as per issue Nov 12, 2022
bedevere-bot mentioned this pull request Nov 12, 2022
Closed

tudortimi commented Nov 13, 2022

Copy link
Copy Markdown

@AA-Turner IMO, kind of strange to mark it as "added in 3.4", since pathlib itself was added in 3.4. The philosophical issue in #99387 remains.

brettcannon changed the title gh-99387 Updated tech docs as per issue gh-99387: Update pathlib.Path.absolute() docs to add versionadded Nov 15, 2022

brettcannon commented Nov 15, 2022

Copy link
Copy Markdown
Member

The decision in the issue is to not make any changes. Thanks anyway for the PR, @Reddragonemperor58 !

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner left review comments
brettcannon Awaiting requested review from brettcannon

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL