FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.11] gh-99357: Close the event loop when it is no longer used in test_uncancel_structured_blocks (GH-99414) by miss-islington · Pull Request #99424 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.11] gh-99357: Close the event loop when it is no longer used in test_uncancel_structured_blocks (GH-99414) - #99424

Merged
gvanrossum merged 2 commits into
python:3.11from
miss-islington:backport-99972dc-3.11
Nov 14, 2022
ConversationCommits (2)ChecksFiles changed
Merged

[3.11] gh-99357: Close the event loop when it is no longer used in test_uncancel_structured_blocks (GH-99414)#99424
gvanrossum merged 2 commits into
python:3.11from
miss-islington:backport-99972dc-3.11

Conversation

miss-islington commented Nov 13, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

pythongh-99357: Close the event loop when it is no longer used in tes…
29f11df 
…t_uncancel_structured_blocks (pythonGH-99414)

(cherry picked from commit 99972dc)

Co-authored-by: Xiao Chen <chenxiao_7@163.com>
bedevere-bot mentioned this pull request Nov 13, 2022
Closed
bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Nov 13, 2022
bedevere-bot mentioned this pull request Nov 13, 2022
Merged

gvanrossum commented Nov 13, 2022

Copy link
Copy Markdown
Member

I'm seeing if the Windows test failure in test_asyncgen was a fluke or repeats itself.

gvanrossum commented Nov 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Unfortunately it keeps failing on Windows, AFAICT in test_asyncio. Maybe closing the loop triggers something funky? Maybe we need to wait for certain events to occur? I guess ProactorEventLoop behaves sufficiently differently that we cannot rule this out. @kumaraditya303

kumaraditya303 commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

Unfortunately it keeps failing on Windows, AFAICT in test_asyncio. Maybe closing the loop triggers something funky? Maybe we need to wait for certain events to occur? I guess ProactorEventLoop behaves sufficiently differently that we cannot rule this out.

See #98219, it isn't related to this PR. I am unable to reproduce on Windows 11 so maybe this only happens on Windows Server versions or slow machines.

gvanrossum commented Nov 14, 2022

Copy link
Copy Markdown
Member

Sadly I cannot merge this with that test failing. I'll try running all the tests one more time, after that I'll invoke the RM.

gvanrossum merged commit 90de4b7 into python:3.11 Nov 14, 2022
miss-islington deleted the backport-99972dc-3.11 branch November 14, 2022 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL