gh-99337: Fix compile errors with gcc 12 on macOS - #99470
Merged
ronaldoussoren merged 6 commits intoNov 21, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ronaldoussoren
marked this pull request as ready for review
November 15, 2022 08:41
vstinner
reviewed
Nov 16, 2022
The new form matches the way we test for other weak symbols (for example in posixmodule.c)
I earlier moved the pragma, but not the comment that explains why it is necessary.
vstinner
approved these changes
Nov 18, 2022
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Oh ok, now with the fixed test if (ffi_closure_free != NULL) {, I get it :-)
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Sorry, @ronaldoussoren, I could not cleanly backport this to 3.10 due to a conflict. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-99638 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 21, 2022
Fix a number of compile errors with GCC-12 on macOS: 1. In pylifecycle.c the compile rejects _Pragma within a declaration 2. posixmodule.c was missing a number of ..._RUNTIME macros for non-clang on macOS 3. _ctypes assumed that __builtin_available is always present on macOS (cherry picked from commit cdde29d) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ronaldoussoren
added a commit
that referenced
this pull request
Nov 21, 2022
…99638) gh-99337: Fix compile errors with gcc 12 on macOS (GH-99470) Fix a number of compile errors with GCC-12 on macOS: 1. In pylifecycle.c the compile rejects _Pragma within a declaration 2. posixmodule.c was missing a number of ..._RUNTIME macros for non-clang on macOS 3. _ctypes assumed that __builtin_available is always present on macOS (cherry picked from commit cdde29d) Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com> Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling with GCC 12 on a macOS 12 system I get three groups of errors: