FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-97001: Release GIL in termios extension by ronaldoussoren · Pull Request #99503 · python/cpython · GitHub

/ cpython Public

GH-97001: Release GIL in termios extension - #99503

Merged
ronaldoussoren merged 4 commits into
python:mainfrom
ronaldoussoren:gh-97001-tcdrain
Nov 22, 2022
ConversationCommits (4)ChecksFiles changed
Merged

GH-97001: Release GIL in termios extension#99503
ronaldoussoren merged 4 commits into
python:mainfrom
ronaldoussoren:gh-97001-tcdrain

Conversation

ronaldoussoren commented Nov 15, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Calls to termios APIs might block, therefore give up the GIL while performing these calls.

bedevere-bot mentioned this pull request Nov 15, 2022
Closed
ronaldoussoren requested a review from a team November 15, 2022 11:36

ronaldoussoren commented Nov 15, 2022

Copy link
Copy Markdown
Contributor Author

IMHO this is a bug fix because you can currently block all Python threads using termios, hence it should be back ported to 3.10 and 3.11.

ronaldoussoren added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 15, 2022
corona10 reviewed Nov 19, 2022
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Overall lgtm,

Super nit: Please unindent between Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS when considering the style of other code bases.

Comment thread Modules/termios.c
Comment thread Modules/termios.c
Comment thread Modules/termios.c
Comment thread Modules/termios.c
Comment thread Modules/termios.c
Comment thread Modules/termios.c
Comment thread Modules/termios.c
Comment thread Modules/termios.c
Comment thread Modules/termios.c
Comment thread Modules/termios.c

ronaldoussoren commented Nov 21, 2022

Copy link
Copy Markdown
Contributor Author

Overall lgtm,

Super nit: Please unindent between Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS when considering the style of other code bases.

I'll change that before merging.

I indent the code between these markers in my own code (including teaching clang-format about this) because this makes it clearer that there's a block of code with slightly different semantics. I prefer my own code style here, but consistency wins.

Dedent the code in Py_*_ALLOW_THREADS blocks
60806bd 
This matches the rest of the code base.
ronaldoussoren merged commit 959ba45 into python:main Nov 22, 2022

miss-islington commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Thanks @ronaldoussoren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Sorry, @ronaldoussoren, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 959ba45d75953caa911e16b4c2a277978fc4b9b0 3.10

bedevere-bot commented Nov 22, 2022

Copy link
Copy Markdown

GH-99679 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 22, 2022
pythonGH-97001: Release GIL in termios extension (pythonGH-99503)
df6bff9 
Without releasing the GIL calls to termios APIs might block the entire interpreter.
(cherry picked from commit 959ba45)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>

bedevere-bot commented Nov 22, 2022

Copy link
Copy Markdown

GH-99680 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 22, 2022
miss-islington added a commit that referenced this pull request Nov 22, 2022
GH-97001: Release GIL in termios extension (GH-99503)
f38eebb 
Without releasing the GIL calls to termios APIs might block the entire interpreter.
(cherry picked from commit 959ba45)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ronaldoussoren added a commit that referenced this pull request Nov 22, 2022
[3.10] GH-97001: Release GIL in termios extension (GH-99503) (#99680)
1c5e860 
Without releasing the GIL calls to termios APIs might block the entire interpreter..
(cherry picked from commit 959ba45)

Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
dpgeorge mentioned this pull request Dec 4, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes

Assignees

ronaldoussoren

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL