FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-99377: Revert audit events for thread state creation and free, because the GIL is not properly held at these times by zooba · Pull Request #99543 · python/cpython · GitHub

/ cpython Public

gh-99377: Revert audit events for thread state creation and free, because the GIL is not properly held at these times - #99543

Merged
zooba merged 3 commits into
python:mainfrom
zooba:gh-99377
Nov 17, 2022
ConversationCommits (3)ChecksFiles changed
Merged

gh-99377: Revert audit events for thread state creation and free, because the GIL is not properly held at these times#99543
zooba merged 3 commits into
python:mainfrom
zooba:gh-99377

Conversation

zooba commented Nov 16, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This can occur during initialization. Without the check, later calls to get the interpreter state will cause a fatal error.

pythongh-99377: Prevent raising audit event when thread state has not…
c732ecc 
… actually been set.

This can occur during initialization. Without the check, later calls to get the interpreter state will cause a fatal error.
bedevere-bot mentioned this pull request Nov 16, 2022
Open
zooba added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Nov 16, 2022

bedevere-bot commented Nov 16, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit c732ecc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 16, 2022
zooba mentioned this pull request Nov 16, 2022
Merged
ericsnowcurrently approved these changes Nov 16, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

I'm surprised _PyThreadState_SetCurrent() can leave it NULL though. Something seems fishy there.

zooba commented Nov 16, 2022

Copy link
Copy Markdown
Member Author

This hasn't done it. Going to revert most of the change (I'll leave the _thread event in there, just not the ThreadState ones)

ericsnowcurrently commented Nov 16, 2022

Copy link
Copy Markdown
Member

FYI, I'm double-checking that that PR was the culprit: gh-99545.

ericsnowcurrently commented Nov 16, 2022

Copy link
Copy Markdown
Member

Looks like a full revert passes all buildbots (actually, 7 still running), so it seems like we're right that the original PR is the source of the failures.

ericsnowcurrently mentioned this pull request Nov 16, 2022
Closed
ericsnowcurrently approved these changes Nov 16, 2022
View reviewed changes

ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

sobolevn commented Nov 16, 2022

Copy link
Copy Markdown
Member

This also closes #99544

zooba changed the title gh-99377: Prevent raising audit event when thread state has not actually been set. gh-99377: Revert audit events for thread state creation and free, because the GIL is not properly held at these times Nov 16, 2022
AlexWaygood linked an issue Nov 16, 2022 that may be closed by this pull request
Buildbots are crashing after #99378 #99544
Closed
zooba merged commit 5fdd49d into python:main Nov 17, 2022
zooba deleted the gh-99377 branch November 17, 2022 00:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Buildbots are crashing after #99378

4 participants

Back | FazBrowse Home | New Git URL