gh-99659: Use correct exceptions in sqlite3 bigmem tests - #99660
Merged
ambv merged 1 commit intoNov 21, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The tests in question were added in 0eec627 by Serhiy. Apparently, sqlite3 changed exceptions raised in those cases in the mean time but the tests never ran because they require a high `-M` setting in the test runner.
ambv
force-pushed
the
sqlite3-bigmem-dataerror
branch
from
3eec87c to
6d69bd1
Compare
November 21, 2022 18:21
serhiy-storchaka
approved these changes
Nov 21, 2022
Copy link
Copy Markdown
Contributor
|
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Sorry, @ambv, I could not cleanly backport this to 3.10 due to a conflict. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 21, 2022
…nGH-99660) The tests in question were added in 0eec627 by Serhiy. Apparently, sqlite3 changed exceptions raised in those cases in the mean time but the tests never ran because they require a high `-M` setting in the test runner. (cherry picked from commit 2781ec9) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Copy link
Copy Markdown
|
GH-99666 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Nevermind the 3.10 backport, those test methods don't exist there (and the test file lives in Lib/sqlite/test/ on that branch). |
Sorry, something went wrong.
miss-islington
added a commit
that referenced
this pull request
Nov 22, 2022
The tests in question were added in 0eec627 by Serhiy. Apparently, sqlite3 changed exceptions raised in those cases in the mean time but the tests never ran because they require a high `-M` setting in the test runner. (cherry picked from commit 2781ec9) Co-authored-by: Łukasz Langa <lukasz@langa.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests in question were added in 0eec627 by Serhiy. Apparently, sqlite3 changed exceptions raised in those cases in the mean time but the tests never ran because they require a high -M setting in the test runner.