gh-99735: Handle no arguments when using sub-commands in argparse - #99736
Closed
ppaez wants to merge 3 commits into
Closed
gh-99735: Handle no arguments when using sub-commands in argparse#99736ppaez wants to merge 3 commits into
ppaez wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
slateny
reviewed
Dec 20, 2022
Comment thread
Doc/library/argparse.rst
Comment on lines
+1855
to
+1858
| One particularly effective way of handling sub-commands is to | ||
| combine the use of the :meth:`add_subparsers` method with calls to | ||
| :meth:`set_defaults` so that each subparser knows which Python | ||
| function it should execute. The :meth:`set_defaults` method of the |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I'd recommend keeping the original structure so just the new changes can be more easily reviewed.
Suggested change
| One particularly effective way of handling sub-commands is to | |
| combine the use of the :meth:`add_subparsers` method with calls to | |
| :meth:`set_defaults` so that each subparser knows which Python | |
| function it should execute. The :meth:`set_defaults` method of the | |
| One particularly effective way of handling sub-commands is to combine the use | |
| of the :meth:`add_subparsers` method with calls to :meth:`set_defaults` so | |
| that each subparser knows which Python function it should execute. | |
| The :meth:`set_defaults` method of the |
Sorry, something went wrong.
Comment thread
Doc/library/argparse.rst
| combine the use of the :meth:`add_subparsers` method with calls to | ||
| :meth:`set_defaults` so that each subparser knows which Python | ||
| function it should execute. The :meth:`set_defaults` method of the | ||
| main parser is called to handle the case when no subcommand is |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
tiny nit, since 'sub-command' was used above in the same paragraph
Suggested change
| main parser is called to handle the case when no subcommand is | |
| main parser is called to handle the case when no sub-command is |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks! Closing in favour of #100927 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a fix to improve the example in the documentation.