FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-66285: skip asyncio fork tests for platforms without md5 hash by kumaraditya303 · Pull Request #99745 · python/cpython · GitHub

/ cpython Public

GH-66285: skip asyncio fork tests for platforms without md5 hash - #99745

Merged
gvanrossum merged 1 commit into
python:mainfrom
kumaraditya303:fix-bots
Nov 24, 2022
ConversationCommits (1)ChecksFiles changed
Merged

GH-66285: skip asyncio fork tests for platforms without md5 hash #99745
gvanrossum merged 1 commit into
python:mainfrom
kumaraditya303:fix-bots

Conversation

kumaraditya303 commented Nov 24, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot mentioned this pull request Nov 24, 2022
Closed
bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Nov 24, 2022
kumaraditya303 added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Nov 24, 2022

bedevere-bot commented Nov 24, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit d450015 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 24, 2022
kumaraditya303 requested a review from ambv November 24, 2022 11:38

kumaraditya303 commented Nov 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This fixes https://buildbot.python.org/all/#/builders/469/builds/3768

Other tests which use multiprocessing also skips test with this decorator.

cpython/Lib/test/_test_multiprocessing.py

Line 3534 in ae185fd

@hashlib_helper.requires_hashdigest('md5')

The refleaks are unrelated.

gvanrossum commented Nov 24, 2022

Copy link
Copy Markdown
Member

Doesn’t seem to have helped. Let’s roll back the other and start over.

kumaraditya303 commented Nov 24, 2022

Copy link
Copy Markdown
Contributor Author

@gvanrossum: The previously broken builtbot now passes with this PR https://buildbot.python.org/all/#/builders/713/builds/844. The refleaks exists on main too and is unrelated, see @ambv message on discord python-dev. Do you see any other issue with this?

gvanrossum approved these changes Nov 24, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The code LGTM. Once we have conformation from @ambv this can be merged.

gvanrossum merged commit 679d963 into python:main Nov 24, 2022
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Nov 24, 2022
Revert "pythonGH-66285: skip asyncio fork tests for platforms without…
cd48f48 
… md5 hash (python#99745)"

This reverts commit 679d963.
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Nov 25, 2022
pythonGH-66285: skip asyncio fork tests for platforms without md5 hash (
6d449e7 
python#99745)

Such buildbots (at the time of writing, only "AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x") cannot use multiprocessing with a fork server, so just skip the test there.
kumaraditya303 deleted the fix-bots branch November 28, 2022 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL