FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-89653: PEP 670: Convert macros to functions by vstinner · Pull Request #99843 · python/cpython · GitHub

Repository navigation

gh-89653: PEP 670: Convert macros to functions - #99843

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:static_inline
Nov 28, 2022
Merged

vstinner merged 2 commits into
python:mainfrom
vstinner:static_inline

Conversation

vstinner commented Nov 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Convert macros to static inline functions to avoid macro pitfalls,
like duplication of side effects:

  • DK_ENTRIES()
  • DK_UNICODE_ENTRIES()
  • PyCode_GetNumFree()
  • PyFloat_AS_DOUBLE()
  • PyInstanceMethod_GET_FUNCTION()
  • PyMemoryView_GET_BASE()
  • PyMemoryView_GET_BUFFER()
  • PyMethod_GET_FUNCTION()
  • PyMethod_GET_SELF()
  • PySet_GET_SIZE()
  • _PyHeapType_GET_MEMBERS()

Changes:

  • Add also assertions in some functions using "CAST" macro to check
    the type of the arguments when Python is built with assertions
    (debug build).
  • Remove an outdated comment in unicodeobject.h.
  • PyCode_GetNumFree() doesn't cast its argument: the replaced macro
    already required the exact type PyCodeObject*.
  • PyCode_GetNumFree() casts PyCode_GetNumFree.co_nfreevars from int
    to Py_ssize_t to be future proof, and because Py_ssize_t is
    commonly used in the C API.

Copy link
Copy Markdown
Member Author

cc @erlend-aasland

Convert macros to static inline functions to avoid macro pitfalls,
like duplication of side effects:

* DK_ENTRIES()
* DK_UNICODE_ENTRIES()
* PyCode_GetNumFree()
* PyFloat_AS_DOUBLE()
* PyInstanceMethod_GET_FUNCTION()
* PyMemoryView_GET_BASE()
* PyMemoryView_GET_BUFFER()
* PyMethod_GET_FUNCTION()
* PyMethod_GET_SELF()
* PySet_GET_SIZE()
* _PyHeapType_GET_MEMBERS()

Changes:

* Add also assertions in some functions using "CAST" macro to check
  the type of the arguments when Python is built with assertions
  (debug build).
* Remove an outdated comment in unicodeobject.h.
* PyCode_GetNumFree() doesn't cast its argument: the replaced macro
  already required the exact type PyCodeObject*.
* PyCode_GetNumFree() casts PyCode_GetNumFree.co_nfreevars from int
  to Py_ssize_t to be future proof, and because Py_ssize_t is
  commonly used in the C API.

Copy link
Copy Markdown
Member Author

I changed PyCode_GetNumFree() return type to Py_ssize_t.

Copy link
Copy Markdown
Member Author

See also PR #99844.

vstinner merged commit 02f72b8 into python:main Nov 28, 2022
vstinner deleted the static_inline branch November 28, 2022 15:40

Copy link
Copy Markdown
Member Author

Merged, thanks for the review @erlend-aasland.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL