gh-99957: Add frozen_default parameter on dataclass_transform - #99958
Merged
JelleZijlstra merged 7 commits intoDec 6, 2022
Merged
gh-99957: Add frozen_default parameter on dataclass_transform#99958JelleZijlstra merged 7 commits into
JelleZijlstra merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
debonte
requested review from
AlexWaygood,
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
December 3, 2022 00:37
hauntsaninja
reviewed
Dec 3, 2022
hauntsaninja
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks! Looks good to me, though you'll need the news entry (might even be worth a What's New bullet point as well).
Sorry, something went wrong.
Comment thread
Lib/typing.py
Outdated
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
sobolevn
reviewed
Dec 4, 2022
Comment thread
Lib/test/test_typing.py
Copy link
Copy Markdown
Contributor
Author
|
@JelleZijlstra, is this good to merge now? |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #99957
Add new frozen_default parameter on dataclass_transform in typing.py.
Update docs and tests.
@JelleZijlstra, @NeilGirdhar, @erictraut, @hauntsaninja, @pradeep90