FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Close PRs when PR opened by hugovk · Pull Request #6 · python/cpython-bin-deps · GitHub

/ cpython-bin-deps Public

Close PRs when PR opened - #6

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:trigger-close-on-open
Oct 30, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Close PRs when PR opened#6
hugovk merged 1 commit into
python:mainfrom
hugovk:trigger-close-on-open

Conversation

hugovk commented Oct 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Re: #5 (comment)

The cron was disabled four months ago:

This scheduled workflow is disabled because there hasn't been activity in this repository for at least 60 days. Enable this workflow to resume scheduled runs.

This triggers the autoclose when opening a PR.

For a demo, see:

(This PR will be autoclosed the next time the schedule runs, we'll just have to re-open it before merge 😅)

hugovk mentioned this pull request Oct 1, 2024
Closed
hauntsaninja reviewed Oct 1, 2024
View reviewed changes

hauntsaninja left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! — will it re-run if we re-open a PR? Just wondering what the merge flow looks like for core devs

Wulian233 commented Oct 1, 2024

Copy link
Copy Markdown

Looks good!

AA-Turner reviewed Oct 1, 2024
View reviewed changes
Comment thread .github/workflows/autoclose.yaml
pull-requests: write

on:
pull_request:

AA-Turner Oct 1, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should let a core dev reopen an auto-closed PR if need be:

GitHub's documentation states:

By default, a workflow only runs when a pull_request event's activity type is opened, synchronize, or reopened.

I haven't tested it, but it seems by default we'd have an auto-close loop.

Suggested change
pull_request:
pull_request:
types:
- opened

This comment was marked as off-topic.

Sign in to view
github-actions Bot closed this Oct 1, 2024
AA-Turner reopened this Oct 1, 2024

github-actions Bot commented Oct 1, 2024

Copy link
Copy Markdown

We do not accept PRs on this repository. Please file an issue at https://github.com/python/cpython requesting an update to the binary packages in this repository.

github-actions Bot closed this Oct 1, 2024

hugovk commented Oct 1, 2024

Copy link
Copy Markdown
Member Author

Thanks! — will it re-run if we re-open a PR? Just wondering what the merge flow looks like for core devs

No, it stayed open after re-open (and was later closed by the hourly cron).

hugovk commented Oct 30, 2024

Copy link
Copy Markdown
Member Author

I'll re-open and merge this :)

hugovk reopened this Oct 30, 2024

github-actions Bot commented Oct 30, 2024

Copy link
Copy Markdown

We do not accept PRs on this repository. Please file an issue at https://github.com/python/cpython requesting an update to the binary packages in this repository.

github-actions Bot closed this Oct 30, 2024

hugovk commented Oct 30, 2024

Copy link
Copy Markdown
Member Author

Bad timing, got hit by the hourly cron:

But GitHub Actions isn't behaving right now (on many repos), with builds taking a long time to start and completed builds showing as yellow. Will try again later when things have settled.

hugovk reopened this Oct 30, 2024
hugovk merged commit a6b94d2 into python:main Oct 30, 2024
hugovk deleted the trigger-close-on-open branch October 30, 2024 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner left review comments
hauntsaninja hauntsaninja left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL