Autoconf shell requirements fix - #19
Merged
corona10 merged 1 commit intoOct 11, 2024
Merged
corona10 merged 1 commit into
corona10 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Problem with autoconf "Rebuilding configure script using /usr/local/bin/autoconf: This script requires a shell more modern than all". in some contexts is fixed with some 'standard' technique. See https://stackoverflow.com/questions/161064/autoconf-using-sh-i-need-shell-bash-how-do-i-force-autoconf-to-use-bash/161128#161128.
efimov-mikhail
requested review from
corona10 and
erlend-aasland
as code owners
October 11, 2024 11:38
2 tasks done
erlend-aasland
approved these changes
Oct 11, 2024
erlend-aasland
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks; looks good to me. I'll let Donghee get a chance to take a look at it before landing.
Sorry, something went wrong.
corona10
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem with autoconf
in some contexts is fixed with some 'standard' technique.
See https://stackoverflow.com/questions/161064/autoconf-using-sh-i-need-shell-bash-how-do-i-force-autoconf-to-use-bash/161128#161128.
Also LABEL org.opencontainers.image.base.name is changed.
It looks like it was a typo in Dockerfile since FROM value differs from image.base.name.
Unfortunately, these changes are not tested by myself since there is no any build instructions.
Simple
docker build .
fails with an error