FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add patch for ax_c_float_words_bigendian.m4 to autoconf-archive by erlend-aasland · Pull Request #23 · python/cpython-devcontainers · GitHub

  1. python
  2. cpython-devcontainers

Repository navigation

Add patch for ax_c_float_words_bigendian.m4 to autoconf-archive - #23

Merged
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:ax-c-float-words-bigendian
Oct 16, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Add patch for ax_c_float_words_bigendian.m4 to autoconf-archive#23
erlend-aasland merged 1 commit into
python:mainfrom
erlend-aasland:ax-c-float-words-bigendian

Conversation

erlend-aasland commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

erlend-aasland linked an issue Oct 15, 2024 that may be closed by this pull request
Patch autoconf-archive with an updated variant of AX_C_FLOAT_WORDS_BIGENDIAN #22
Closed

erlend-aasland commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator Author

The original autoconf-archive PR is here:

corona10 self-assigned this Oct 16, 2024
corona10 approved these changes Oct 16, 2024
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm!!

corona10 reviewed Oct 16, 2024
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@erlend-aasland
Nit comment:
If we have to vendor more custom patch, it might good to have own directory under autoconf, (e.g autoconf/diff)

corona10 assigned erlend-aasland and unassigned corona10 Oct 16, 2024

corona10 commented Oct 16, 2024

Copy link
Copy Markdown
Member

Feel free to merge this PR and publish new release when you want! through https://github.com/python/cpython-devcontainers/actions/workflows/release.yml

erlend-aasland commented Oct 16, 2024

Copy link
Copy Markdown
Collaborator Author

@erlend-aasland Nit comment: If we have to vendor more custom patch, it might good to have own directory under autoconf, (e.g autoconf/diff)

Yes, I thought about that, but I do not anticipate, nor hope, that there will be many patches :) If another patch is needed, let's introduce a more formal system for maintaining them.

erlend-aasland merged commit d5e7029 into python:main Oct 16, 2024
erlend-aasland deleted the ax-c-float-words-bigendian branch October 16, 2024 07:26
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Oct 16, 2024
pythongh-89640: properly detect float word ordering on Linux
bd20441 
Prerequisite: python/cpython-devcontainers#23

autoconf-archive patch by Dan Amelang.
erlend-aasland mentioned this pull request Oct 16, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes

Assignees

erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Patch autoconf-archive with an updated variant of AX_C_FLOAT_WORDS_BIGENDIAN

2 participants

Back | FazBrowse Home | New Git URL