Update patchcheck description - #1031
Merged
ezio-melotti merged 3 commits intoJan 16, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
CAM-Gerlach
reviewed
Jan 15, 2023
CAM-Gerlach
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Maybe worth updating the CPython source file paths in this section to use :cpy-file:, so that the actual files are linked directly, and in the future linkcheck will report a warning if they are ever moved or deleted again?
Sorry, something went wrong.
Comment thread
getting-started/pull-request-lifecycle.rst
Outdated
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach
approved these changes
Jan 16, 2023
CAM-Gerlach
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks, FWIW
Sorry, something went wrong.
ezio-melotti
approved these changes
Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patchcheck.py, reindent.py are moved from Tools\scripts\ to Tools\patchcheck\
Ref: python/cpython#98186
reindent-rst.py are deleted.
whitespaces in docs are handled by patchcheck.py itself
Ref: python/cpython#97675