FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use targeted env vars for overriding compiler/linker args on macOS by erlend-aasland · Pull Request #1058 · python/devguide · GitHub

Use targeted env vars for overriding compiler/linker args on macOS - #1058

Merged
erlend-aasland merged 5 commits into
python:mainfrom
erlend-aasland:macos-build
Jun 8, 2023
Merged

Use targeted env vars for overriding compiler/linker args on macOS#1058
erlend-aasland merged 5 commits into
python:mainfrom
erlend-aasland:macos-build

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

erlend-aasland linked an issue Feb 22, 2023 that may be closed by this pull request

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FWIW, this looks good from a docs perspective—ultimately up to the subject matter experts (Ned, etc) of course.

Copy link
Copy Markdown
Member

I like this approach but, as I've just discovered, Homebrew has just changed the game again by making their tcl-tk formula no longer "keg-only". As noted here, we should re-think this a bit in that light. I'll have some more thoughts on it soon.

ned-deily added the DO-NOT-MERGE Do not merge this PR label Feb 26, 2023

Copy link
Copy Markdown
Contributor Author

I like this approach but, as I've just discovered, Homebrew has just changed the game again by making their tcl-tk formula no longer "keg-only". As noted here, we should re-think this a bit in that light. I'll have some more thoughts on it soon.

Ouch, it's unfortunate that our build instructions are so dependent on Homebrew distribution specifics. Let's create a separate issue for this (unless you already did so).

erlend-aasland marked this pull request as draft March 10, 2023 11:27

Copy link
Copy Markdown
Contributor Author

As noted python/cpython#102186 (comment), we should re-think this a bit in that light. I'll have some more thoughts on it soon.

I've marked this as a draft until the above has landed.

erlend-aasland commented Mar 22, 2023
edited
Loading

Copy link
Copy Markdown
Contributor Author

I like this approach but, as I've just discovered, Homebrew has just changed the game again by making their tcl-tk formula no longer "keg-only". As noted here, we should re-think this a bit in that light. I'll have some more thoughts on it soon.

@ned-deily, have you had the chance to think about this issue? IMO, it is unfortunate that we rely on Homebrew specifics. Perhaps the best thing to do, is to update the devguide recommendations for how to install the dependencies:

$ brew install pkg-config openssl@1.1 xz gdbm tcl-tk
$ brew link tcl-tk  # <= may produce a warning if already linked

We can then carry on with this PR (and also update the devguide build steps again).

Copy link
Copy Markdown
Member

@ned-deily, have you had the chance to think about this issue? IMO, it is unfortunate that we rely on Homebrew specifics. Perhaps the best thing to do, is to update the devguide recommendations for how to install the dependencies:

That could be an option. There are a number of other side issues with some of the other dependencies, like which ones should we use from the operating system, and there are the Homebrew differences between Intel and Apple Silicon installations. Alas, I am away right now but will get back to this in a couple of weeks. If you think there is a need to update the guide sooner, we can always tweak it again later.

Copy link
Copy Markdown
Contributor Author

No, there's no hurry 🙂 If you're coming to SLC, we can discuss it there. If not, let's pick it up when you're ready.

Comment thread getting-started/setup-building.rst Outdated
erlend-aasland marked this pull request as ready for review June 8, 2023 20:35

Copy link
Copy Markdown
Contributor Author

@ned-deily, let's land this. We can handle the OpenSSL version in a follow-up PR (python/cpython#99079 (comment))

erlend-aasland requested a review from ned-deily June 8, 2023 20:37

ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO-NOT-MERGE Do not merge this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use targeted env vars for macOS build instructions

4 participants


Back | FazBrowse Home | New Git URL