FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add guidelines for C API return values by erlend-aasland · Pull Request #1123 · python/devguide · GitHub

/ devguide Public

Add guidelines for C API return values - #1123

Merged
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:c-api/guidelines-return-value
Jun 26, 2023
ConversationCommits (4)ChecksFiles changed
Merged

Add guidelines for C API return values#1123
erlend-aasland merged 4 commits into
python:mainfrom
erlend-aasland:c-api/guidelines-return-value

Conversation

erlend-aasland commented Jun 23, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland linked an issue Jun 23, 2023 that may be closed by this pull request
Document the preferred style for API functions with three, four or five-way returns #1121
Closed
erlend-aasland mentioned this pull request Jun 23, 2023
Closed
markshannon approved these changes Jun 23, 2023
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me, as a first step.

erlend-aasland mentioned this pull request Jun 23, 2023
Closed
erlend-aasland linked an issue Jun 23, 2023 that may be closed by this pull request
Document that infallible functions should be avoided #1122
Closed
vstinner reviewed Jun 23, 2023
View reviewed changes
Comment thread developer-workflow/c-api.rst
CAM-Gerlach reviewed Jun 23, 2023
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A couple small textual tweaks, otherwise LGTM

Comment thread developer-workflow/c-api.rst Outdated
Comment thread developer-workflow/c-api.rst Outdated
Apply suggestions from CAM's review
8458b6f 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach approved these changes Jun 23, 2023
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks @erlend-aasland !

This was referenced Jun 24, 2023
Open
Open

erlend-aasland commented Jun 25, 2023

Copy link
Copy Markdown
Contributor Author

Unless there are further remarks, I consider landing this early the coming week.

vstinner approved these changes Jun 26, 2023
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

erlend-aasland commented Jun 26, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews!

FTR, I also got a thumbs up by Thomas Wouters for this PR.

erlend-aasland merged commit 3f08d25 into python:main Jun 26, 2023
erlend-aasland deleted the c-api/guidelines-return-value branch June 26, 2023 07:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
markshannon markshannon approved these changes
CAM-Gerlach CAM-Gerlach approved these changes
encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document that infallible functions should be avoided Document the preferred style for API functions with three, four or five-way returns

4 participants

Back | FazBrowse Home | New Git URL