FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clarify that PyUnstable macros use "PyUnstable" prefix by vstinner · Pull Request #1158 · python/devguide · GitHub

  1. python
  2. devguide

Repository navigation

Clarify that PyUnstable macros use "PyUnstable" prefix - #1158

Merged
willingc merged 1 commit into
python:mainfrom
vstinner:pyunstable
Sep 29, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Clarify that PyUnstable macros use "PyUnstable" prefix#1158
willingc merged 1 commit into
python:mainfrom
vstinner:pyunstable

Conversation

vstinner commented Sep 1, 2023 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

vstinner mentioned this pull request Sep 1, 2023
Closed

vstinner commented Sep 1, 2023

Copy link
Copy Markdown
Member Author

My previous abandoned PR for the Python documentation (Doc/c-api/stable.rst): python/cpython#108710

cc @encukou

willingc approved these changes Sep 29, 2023
View reviewed changes

willingc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks like a reasonable clarification and guidance to me.

willingc commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

@vstinner I'm going to merge. If @encukou has a different viewpoint, we can always go back and modify. Thanks Victor.

willingc merged commit fd1c58f into python:main Sep 29, 2023
vstinner deleted the pyunstable branch September 29, 2023 19:43

vstinner commented Sep 29, 2023

Copy link
Copy Markdown
Member Author

You're welcome Carol.

encukou commented Oct 2, 2023

Copy link
Copy Markdown
Member

Sorry, I dropped the ball here. Thank you Carol for picking it up!

A technicality: I wouldn't call macros symbols -- it's better to reserve that term to the stuff that's exported from a .so/DLL.

But with the list of examples, it's fine.

vstinner commented Oct 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

A technicality: I wouldn't call macros symbols -- it's better to reserve that term to the stuff that's exported from a .so/DLL.

Maybe names is a better term here.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

willingc willingc approved these changes
encukou Awaiting requested review from encukou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL