gh-1178: fix indentation in the argument clinic page. - #1180
Merged
pradyunsg merged 1 commit intoOct 9, 2023
Merged
pradyunsg merged 1 commit into
pradyunsg merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
6 tasks done
ezio-melotti
commented
Oct 9, 2023
Comment thread
development-tools/clinic.rst
Comment on lines
+1743
to
+1754
| ``{path}`` | ||
| The full path to the file, including directory and full filename. | ||
| ``{dirname}`` | ||
| The name of the directory the file is in. | ||
| ``{basename}`` | ||
| Just the name of the file, not including the directory. | ||
| ``{basename_root}`` | ||
| Basename with the extension clipped off | ||
| (everything up to but not including the last '.'). | ||
| ``{basename_extension}`` | ||
| The last '.' and everything after it. If the basename | ||
| does not contain a period, this will be the empty string. |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Here I added some markup.
Sorry, something went wrong.
Comment thread
development-tools/clinic.rst
Comment on lines
+1756
to
+1758
| If there are no periods in the filename, ``{basename}`` and ``{filename}`` | ||
| are the same, and ``{extension}`` is empty. ``{basename}{extension}`` | ||
| is always exactly the same as ``{filename}``. |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Here too, and also removed what appeared to by a stray " at the end.
Sorry, something went wrong.
hugovk
approved these changes
Oct 9, 2023
pradyunsg
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the indentation of several blocks in the https://devguide.python.org/development-tools/clinic/ page that were rendered as blockquotes as described in #1178.
📚 Documentation preview 📚: https://cpython-devguide--1180.org.readthedocs.build/development-tools/clinic/