FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Document how to use varargs in Argument Clinic by aisk · Pull Request #1277 · python/devguide · GitHub

  1. python
  2. devguide

Repository navigation

Document how to use varargs in Argument Clinic - #1277

Closed
aisk wants to merge 7 commits into
python:mainfrom
aisk:ac-varargs
ConversationCommits (7)ChecksFiles changed
Closed

Document how to use varargs in Argument Clinic#1277
aisk wants to merge 7 commits into
python:mainfrom
aisk:ac-varargs

Conversation

aisk commented Feb 23, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

This is related to python/cpython#64490

📚 Documentation preview 📚: https://cpython-devguide--1277.org.readthedocs.build/

erlend-aasland self-requested a review February 23, 2024 23:48
ezio-melotti reviewed Feb 25, 2024
View reviewed changes

ezio-melotti left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This might be higher up in the list.
Should **kwargs be documented too, possibly together with *args?

aisk commented Feb 25, 2024

Copy link
Copy Markdown
Member Author

Thanks for the review!

This might be higher up in the list.

Is it ok to move it below How to convert METH_O and METH_NOARGS functions?

Should **kwargs be documented too, possibly together with *args?

According to python/cpython#64490, **kwargs is not supported by Argument Clinic.

aisk requested a review from ezio-melotti April 21, 2024 15:47

willingc commented Oct 12, 2024

Copy link
Copy Markdown
Collaborator

@ezio-melotti You have more experience with this tool than I do. Is this PR ready for merge?

ezio-melotti commented Oct 12, 2024

Copy link
Copy Markdown
Member

LGTM. @erlend-aasland?

JelleZijlstra reviewed Oct 13, 2024
View reviewed changes
Comment thread development-tools/clinic.rst

To convert a var-positional parameter function,
prepending the parameter name with ``*`` ,
and the parameter should use the ``object`` converter::

JelleZijlstra Oct 13, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What happens if I use something else? E.g., what if I want to accept an arbitrary number of ints?

Also, what type does the implementation function receive?

aisk Oct 13, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for the review! I have added a new paragraph to explain more about it.

picnixz reviewed Oct 13, 2024
View reviewed changes
Comment thread development-tools/clinic.rst Outdated
Comment thread development-tools/clinic.rst
Update development-tools/clinic.rst
7d6c9c9 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
aisk closed this by deleting the head repository Jul 25, 2025
skirpichev mentioned this pull request Aug 12, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra left review comments
picnixz picnixz left review comments
willingc willingc approved these changes
erlend-aasland Awaiting requested review from erlend-aasland
ezio-melotti Awaiting requested review from ezio-melotti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL