FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update `translations/coordinating.rst` by StanFromIreland · Pull Request #1587 · python/devguide · GitHub

  1. python
  2. devguide

Repository navigation

Update translations/coordinating.rst - #1587

Merged
encukou merged 10 commits into
python:mainfrom
StanFromIreland:coordinating
Aug 18, 2025
ConversationCommits (10)ChecksFiles changed
Merged

Update translations/coordinating.rst#1587
encukou merged 10 commits into
python:mainfrom
StanFromIreland:coordinating

Conversation

StanFromIreland commented Jun 23, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

This page is aimed at coordinators, so I assume some git/gh knowledge etc.

Some things that need to be discussed:

closes #1586

📚 Documentation preview 📚: https://cpython-devguide--1587.org.readthedocs.build/

StanFromIreland requested a review from willingc June 23, 2025 09:37
StanFromIreland mentioned this pull request Jun 23, 2025
Merged

StanFromIreland commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

While this has to wait for a pending issue, other discussion should continue. These are comments I left in the file in the format, XXX thought.

Requesting @rffontenelle and @m-aciek

StanFromIreland marked this pull request as ready for review June 24, 2025 19:06
rffontenelle suggested changes Jun 24, 2025
View reviewed changes

rffontenelle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for improving the docs. Please find some notes below

Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
StanFromIreland linked an issue Jun 27, 2025 that may be closed by this pull request
Move docs build scripts info from intro paragraph to the Coordinating FAQ for translations #1585
Closed
hugovk reviewed Jun 27, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Partial review

Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated

StanFromIreland commented Jun 27, 2025

Copy link
Copy Markdown
Member Author

Thanks for the review.

I should have my editor highlight it in red:-)

StanFromIreland requested a review from hugovk June 27, 2025 13:46
ezio-melotti reviewed Jun 28, 2025
View reviewed changes
Comment thread documentation/translations/coordinating.rst
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
m-aciek requested changes Jun 28, 2025
View reviewed changes
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst
Comment thread documentation/translations/coordinating.rst
Comment thread documentation/translations/coordinating.rst
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
StanFromIreland mentioned this pull request Jul 10, 2025
Closed
marcorichetta mentioned this pull request Jul 24, 2025
Merged
1 task done

StanFromIreland commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Since this pr is taking a while (due to it's size already), we can leave the todos that need discussion to follow ups. Would it be possible to get a review @willingc?

hugovk reviewed Aug 5, 2025
View reviewed changes
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Comment thread documentation/translations/coordinating.rst Outdated
Apply suggestions from code review
7b86d86 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

StanFromIreland commented Aug 5, 2025

Copy link
Copy Markdown
Member Author

Thanks for making them suggestions!

willingc commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator

Thanks @hugovk for reviewing. I tried to review this morning and hit 500 errors from GitHub. Will review now.

willingc approved these changes Aug 5, 2025
View reviewed changes

willingc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @StanFromIreland for making these changes.

StanFromIreland mentioned this pull request Aug 6, 2025
Open

StanFromIreland commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

Anything left to do to get this merged?

encukou merged commit b0aefe9 into python:main Aug 18, 2025
StanFromIreland deleted the coordinating branch August 18, 2025 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments
willingc willingc approved these changes
ezio-melotti Awaiting requested review from ezio-melotti
m-aciek Awaiting requested review from m-aciek
rffontenelle Awaiting requested review from rffontenelle

Assignees

No one assigned

Labels

None yet

Projects

Translation issues & improvements 🌍
Status: Done

Milestone

No milestone

7 participants

Back | FazBrowse Home | New Git URL