FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Document when a review can be dismissed. by Mariatta · Pull Request #176 · python/devguide · GitHub

  1. python
  2. devguide

Repository navigation

Document when a review can be dismissed. #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willingc merged 1 commit into from
Apr 24, 2017
Conversation 1 Commits 1 Checks 0 Files changed
Merged

Document when a review can be dismissed. #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .rst  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
9 changes: 9 additions & 0 deletions pullrequest.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,15 @@ code and leave comments in the pull request or issue tracker.
'merge-ready', you should always make sure the entire test suite passes.


Dismissing Review from Another Core Developer
---------------------------------------------

A core developer can dismiss another core developer's review if they confirmed
that the requested changes have been made. When a core developer has assigned
the PR to themselves, then it is a sign that they are actively looking after
the PR, and their review should not be dismissed.


Committing/Rejecting
--------------------

Expand Down
Back | FazBrowse Home | New Git URL