Argument Clinic: document deletion of an attribute and @deleter - #1886
Merged
serhiy-storchaka merged 2 commits intoAug 19, 2026
Merged
Argument Clinic: document deletion of an attribute and @deleter#1886serhiy-storchaka merged 2 commits into
serhiy-storchaka merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Also update the example of the generated code.
Copy link
Copy Markdown
Documentation build overview4 files changed ± versions/index.html ± developer-workflow/extension-modules/index.html ± development-tools/clinic/howto/index.html ± development-tools/clinic/tutorial/index.html |
Sorry, something went wrong.
encukou
reviewed
Aug 19, 2026
Comment thread
development-tools/clinic/howto.rst
Outdated
JelleZijlstra
approved these changes
Aug 19, 2026
Co-authored-by: Petr Viktorin <encukou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setter generated by Argument Clinic is called with NULL to delete the attribute, and by default it rejects the deletion with an AttributeError. The @deleter directive, applied to the @setter, lets the implementation handle the deletion. Neither was documented.
The example of the generated code is also updated -- it was written before the accessors started to take PyObject *self.