Added copyright link for the devguide - #665
jablonskidev wants to merge 1 commit into
Conversation
Sorry, something went wrong.
In order to resolve issues python#652 and python#653 in the devguide (which are duplicates of each other), we added a theme variable to `python_docs_theme/layout.html` in PR python#67. This will allow all users of the python-docs-theme library to have more functionality and backwards compatibility. In addition, if users don't define a link for copyright information, then they won't have a broken link that leads to nowhere in their page footer. In order to have the correct copyright link for the devguide specifically, we just needed to specify it in the `html_theme_options` dictionary in the devguide's `conf.py`, which I did in this commit.
|
@CAM-Gerlach The build failed because the changes to python_docs_theme/layout.html that we discussed in PR #67 for python-docs-theme have not yet been merged. Here's the error message:
From what I understand, I just need to wait for you to merge the changes to python_docs_theme/layout.html, and then we can test that the changes I'm proposing in this PR work. |
Sorry, something went wrong.
|
Yup, exactly, except I'm not an org member, just a drive-by contributor, so I can't merge anything haha! That's up to @Mariatta , I assume, and depends on how you have your infra set up to pull in the theme (which I'm not really familiar with). Thanks! |
Sorry, something went wrong.
|
Could you check with my python/python-docs-theme#67 (comment) ? Thank you |
Sorry, something went wrong.
|
Hey, looks like the theme changes were merged @jablonskidev . Any chance this could get a rebuild? |
Sorry, something went wrong.
|
Let's close this because the devguide is now using the Furo theme instead (#679) which doesn't support the copyright_url option: But thanks anyway for the PR! |
Sorry, something went wrong.
|
Oh well; so much for all that, heh. |
Sorry, something went wrong.
|
On the bright side, python_docs_theme was improved for others :) |
Sorry, something went wrong.
In order to resolve issues #652 and #653 in the devguide (which are duplicates of each other), we added a theme variable to python_docs_theme/layout.html in PR #67. This will allow all users of the python-docs-theme library to have more functionality and backwards compatibility. In addition, if users don't define a link for copyright information, then they won't have a broken link that leads to nowhere in their page footer.
In order to have the correct copyright link for the devguide specifically, we just needed to specify it in the html_theme_options dictionary in the devguide's conf.py, which I did in this commit.