Use sphinx-lint in make check. - #866
Merged
ezio-melotti merged 4 commits intoMay 16, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
hugovk
reviewed
May 16, 2022
Comment thread
Makefile
Outdated
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
approved these changes
May 16, 2022
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
zooba
reviewed
May 16, 2022
zooba
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Guess it looks good, though I haven't tested it and am not sure what it's doing other than installing a package. But the batch file syntax seems okay
Sorry, something went wrong.
Comment thread
make.bat
Outdated
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
AA-Turner
pushed a commit
to AA-Turner/devguide
that referenced
this pull request
Jun 17, 2022
* Use sphinx-lint in `make check`. * Fix missing newlines at the end of files. * Add `venv` as a dependency for the `check` target. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Specify `sphinx-lint` version in `make.bat`. Co-authored-by: Steve Dower <steve.dower@microsoft.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Steve Dower <steve.dower@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of python/cpython#92290 which updates make check to use sphinx-lint.