FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Pin sphinx-lint to fix the CI by hugovk · Pull Request #955 · python/devguide · GitHub

Pin sphinx-lint to fix the CI - #955

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
hugovk:pin-sphinx-lint
Oct 6, 2022
Merged

Pin sphinx-lint to fix the CI#955
JelleZijlstra merged 1 commit into
python:mainfrom
hugovk:pin-sphinx-lint

Conversation

hugovk commented Oct 6, 2022
edited
Loading

Copy link
Copy Markdown
Member

Between PR #954 being opened (CI passed) and merged 25 minutes later (CI failed), a new release of sphinx-lint came out with differing checks.

Let's pin it to get the CI green, and I'll open an issue to upgrade and fix the issues.

Copy link
Copy Markdown
Member

new release of sphinx-lint came out with differing checks.

Or with bugs. From a code diff of python/cpython#97962:

sphinx-lint 0.6.2 yields many default role errors due to the new regular expression used for default role detection, so we don't use the version until the errors are fixed.

Copy link
Copy Markdown
Member

Or with bugs. From a code diff of python/cpython#97962:

... the errors are fixed.

I meant the errors in CPython's reStructuredText sources in that comment, I'm assuming the changes in sphinx-lint are correct. I haven't checked either, though.

A

JelleZijlstra merged commit 1e315c0 into python:main Oct 6, 2022

Copy link
Copy Markdown
Member

I didn't check in detail but the amount of errors in CI does suggest a bug in sphinx-lint.

hugovk deleted the pin-sphinx-lint branch October 6, 2022 18:25

hugovk commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

Yes, reported here: sphinx-contrib/sphinx-lint#46

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL