Move .PHONY to each section to avoid copy/paste omissions - #972
Merged
JelleZijlstra merged 1 commit intoOct 21, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JelleZijlstra
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to python/cpython#98189, the list of phony targets in the Makefile had got out of sync with the commands: clean-venv, ensure-venv and serve were missing.
I expect it will happen again because it's easy to copy and paste a target and not realise/remember to update the list of .PHONY targets at the top of the file.
Let's do as @zware suggested in python/cpython#98189 (comment) and put each one right next to its target.
We do this at Pillow and at work, it helps a lot.
(See also python/cpython#98266 to update the CPython docs Makefile and python/peps#2841 for PEPs.)