Exit the script process with non-zero status - #150
Merged
JulienPalard merged 1 commit intoMar 14, 2023
Merged
JulienPalard merged 1 commit into
JulienPalard merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
m-aciek
force-pushed
the
exit-code
branch
2 times, most recently
from
ccc8d99 to
2694420
Compare
March 12, 2023 00:56
pradyunsg
reviewed
Mar 12, 2023
Comment thread
build_docs.py
Outdated
Copy link
Copy Markdown
Contributor
Author
|
I've squashed the changes to avoid merging my reverts to main branch. |
Sorry, something went wrong.
JulienPalard
approved these changes
Mar 14, 2023
Copy link
Copy Markdown
Member
|
Thanks for this PR! It even feel strange that it has not been implemented sooner ;) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exit the script process with status EX_SOFTWARE (70, non-zero) if at least one build was unsuccessful.
Fixes false negatives given by build_docs.py script when using in CI. Stumbled upon in python-docs-theme CI.