FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump versions table in README by hugovk · Pull Request #156 · python/docsbuild-scripts · GitHub

/ docsbuild-scripts Public

Bump versions table in README - #156

Merged
JulienPalard merged 6 commits into
python:mainfrom
hugovk:update-versions
Oct 6, 2023
ConversationCommits (6)ChecksFiles changed
Merged

Bump versions table in README#156
JulienPalard merged 6 commits into
python:mainfrom
hugovk:update-versions

Conversation

hugovk commented May 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

By running python check_versions.py ../cpython/

Also update the requirements to fix:

❯ python check_versions.py ../cpython/
Traceback (most recent call last):
  File "/Users/hugo/github/docsbuild-scripts/check_versions.py", line 13, in <module>
    import build_docs
  File "/Users/hugo/github/docsbuild-scripts/build_docs.py", line 45, in <module>
    import zc.lockfile
ModuleNotFoundError: No module named 'zc'

JulienPalard commented Oct 5, 2023

Copy link
Copy Markdown
Member

Wow this PR went too long without love :(

Can you remove the mentions of ## The github hook server in the README? It has been removed in the meantime and your PR is reintroducing it.

hugovk commented Oct 5, 2023

Copy link
Copy Markdown
Member Author

I've updated from main and bumped the versions again.

It has been removed in the meantime and your PR is reintroducing it.

I can still see ## The github hook server in the README?

https://github.com/python/docsbuild-scripts#the-github-hook-serverx

This PR only fixes some typos in that section (Github -> GitHub).

JulienPalard merged commit 38f1fd2 into python:main Oct 6, 2023
hugovk deleted the update-versions branch October 6, 2023 19:35
pradyunsg mentioned this pull request Oct 7, 2023
Open

pradyunsg commented Oct 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

In #170, I've made a suggestion that would remove the need for README version bump PRs in the future, by throwing automation/CI at the problem.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pradyunsg pradyunsg approved these changes
ezio-melotti ezio-melotti approved these changes
+1 more reviewer
egeakman egeakman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL